Changeset 204115 in webkit

Timestamp:

Aug 3, 2016, 10:26:58 PM (9 years ago)

Author:

Chris Dumez

Message:

Object.getOwnPropertyNames() on NamedNodeMap fails to return named properties
​https://bugs.webkit.org/show_bug.cgi?id=160517

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

• web-platform-tests/dom/collections/namednodemap-supported-property-names-expected.txt:
• web-platform-tests/dom/nodes/attributes-expected.txt:

Source/WebCore:

Object.getOwnPropertyNames() on NamedNodeMap should return named
properties' names as per:

• ​https://dom.spec.whatwg.org/#dom-namednodemap-item

No new tests, rebaselined existing tests.

• dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::supportedPropertyNames):

• dom/NamedNodeMap.h:

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/dom/collections/namednodemap-supported-property-names-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/dom/nodes/attributes-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/NamedNodeMap.cpp (modified) (2 diffs)
• Source/WebCore/dom/NamedNodeMap.h (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2016-08-03  Chris Dumez  <cdumez@apple.com>
+
+        Object.getOwnPropertyNames() on NamedNodeMap fails to return named properties
+        https://bugs.webkit.org/show_bug.cgi?id=160517
+
+        Reviewed by Alex Christensen.
+
+        Rebaseline several W3C tests now that more checks are passing.
+
+        * web-platform-tests/dom/collections/namednodemap-supported-property-names-expected.txt:
+        * web-platform-tests/dom/nodes/attributes-expected.txt:
+
 2016-08-03  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/dom/collections/namednodemap-supported-property-names-expected.txt

@@ -1 +1 @@
 
-FAIL Object.getOwnPropertyNames on NamedNodeMap assert_array_equals: lengths differ, expected 4 got 2
-FAIL Object.getOwnPropertyNames on NamedNodeMap of input assert_array_equals: lengths differ, expected 8 got 4
-FAIL Object.getOwnPropertyNames on NamedNodeMap after attribute removal assert_array_equals: lengths differ, expected 6 got 3
+PASS Object.getOwnPropertyNames on NamedNodeMap 
+PASS Object.getOwnPropertyNames on NamedNodeMap of input 
+PASS Object.getOwnPropertyNames on NamedNodeMap after attribute removal 
 Simple
 

trunk/LayoutTests/imported/w3c/web-platform-tests/dom/nodes/attributes-expected.txt

@@ -50 +50 @@
 PASS setAttributeNode called with an Attr that has the same name as an existing one should not change attribute order 
 PASS getAttributeNames tests 
-FAIL Own property correctness with basic attributes assert_array_equals: lengths differ, expected 4 got 2
-FAIL Own property correctness with non-namespaced attribute before same-name namespaced one assert_array_equals: lengths differ, expected 5 got 3
-FAIL Own property correctness with namespaced attribute before same-name non-namespaced one assert_array_equals: lengths differ, expected 5 got 3
-FAIL Own property correctness with two namespaced attributes with the same name-with-prefix assert_array_equals: lengths differ, expected 5 got 3
-FAIL Own property names should only include all-lowercase qualified names for an HTML element in an HTML document assert_array_equals: lengths differ, expected 8 got 6
-FAIL Own property names should include all qualified names for a non-HTML element in an HTML document assert_array_equals: lengths differ, expected 12 got 6
-FAIL Own property names should include all qualified names for an HTML element in a non-HTML document assert_array_equals: lengths differ, expected 12 got 6
+PASS Own property correctness with basic attributes 
+PASS Own property correctness with non-namespaced attribute before same-name namespaced one 
+PASS Own property correctness with namespaced attribute before same-name non-namespaced one 
+PASS Own property correctness with two namespaced attributes with the same name-with-prefix 
+PASS Own property names should only include all-lowercase qualified names for an HTML element in an HTML document 
+PASS Own property names should include all qualified names for a non-HTML element in an HTML document 
+PASS Own property names should include all qualified names for an HTML element in a non-HTML document 
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-08-03  Chris Dumez  <cdumez@apple.com>
+
+        Object.getOwnPropertyNames() on NamedNodeMap fails to return named properties
+        https://bugs.webkit.org/show_bug.cgi?id=160517
+
+        Reviewed by Alex Christensen.
+
+        Object.getOwnPropertyNames() on NamedNodeMap should return named
+        properties' names as per:
+        - https://dom.spec.whatwg.org/#dom-namednodemap-item
+
+        No new tests, rebaselined existing tests.
+
+        * dom/NamedNodeMap.cpp:
+        (WebCore::NamedNodeMap::supportedPropertyNames):
+        * dom/NamedNodeMap.h:
+
 2016-08-03  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/dom/NamedNodeMap.cpp

@@ -29 +29 @@
 #include "Element.h"
 #include "ExceptionCode.h"
+#include "HTMLDocument.h"
+#include "HTMLElement.h"
 
 namespace WebCore {
@@ -64 +66 @@
 }
 
-Vector<AtomicString> NamedNodeMap::supportedPropertyNames()
+Vector<String> NamedNodeMap::supportedPropertyNames()
 {
-    // FIXME: Should be implemented.
-    return Vector<AtomicString>();
+    Vector<String> names = m_element.getAttributeNames();
+    if (is<HTMLElement>(m_element) && is<HTMLDocument>(m_element.document())) {
+        names.removeAllMatching([](String& name) {
+            return name.convertToASCIILowercase() != name;
+        });
+    }
+    return names;
 }
 

trunk/Source/WebCore/dom/NamedNodeMap.h

@@ -54 +54 @@
     RefPtr<Attr> getNamedItem(const AtomicString&) const;
     RefPtr<Attr> removeNamedItem(const AtomicString& name, ExceptionCode&);
-    Vector<AtomicString> supportedPropertyNames();
+    Vector<String> supportedPropertyNames();
 
     RefPtr<Attr> getNamedItemNS(const AtomicString& namespaceURI, const AtomicString& localName) const;