Changeset 206387 in webkit

Timestamp:

Sep 26, 2016, 12:55:08 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK][EFL] imported/w3c/web-platform-tests/fetch/api/basic/accept-header.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=162547

Patch by Youenn Fablet <​youenn@apple.com> on 2016-09-26
Reviewed by Carlos Garcia Campos.

Covered by LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header.html now passing.

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::createTestingSession): Setting a default Accept-Language value.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/soup/SoupNetworkSession.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-26  Youenn Fablet  <youenn@apple.com>
+
+        [GTK][EFL] imported/w3c/web-platform-tests/fetch/api/basic/accept-header.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=162547
+
+        Reviewed by Carlos Garcia Campos.
+
+        Covered by LayoutTests/imported/w3c/web-platform-tests/fetch/api/basic/accept-header.html now passing.
+
+        * platform/network/soup/SoupNetworkSession.cpp:
+        (WebCore::SoupNetworkSession::createTestingSession): Setting a default Accept-Language value.
+
 2016-09-26  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp

@@ -64 +64 @@
 std::unique_ptr<SoupNetworkSession> SoupNetworkSession::createTestingSession()
 {
-    GRefPtr<SoupCookieJar> cookieJar = adoptGRef(createPrivateBrowsingCookieJar());
-    return std::unique_ptr<SoupNetworkSession>(new SoupNetworkSession(cookieJar.get()));
+    auto cookieJar = adoptGRef(createPrivateBrowsingCookieJar());
+    auto newSoupSession = std::unique_ptr<SoupNetworkSession>(new SoupNetworkSession(cookieJar.get()));
+    // FIXME: Creating a testing session is losing soup session values set when initializing the network process.
+    g_object_set(newSoupSession.get(), "accept-language", "en-us", nullptr);
+    return newSoupSession;
 }