Changeset 206520 in webkit

Timestamp:

Sep 28, 2016, 9:26:44 AM (9 years ago)

Author:

jer.noble@apple.com

Message:

PiP shows incorrect state of play button.
​https://bugs.webkit.org/show_bug.cgi?id=162652

Reviewed by Eric Carlson.

After getting a new WebPlaybackSessionModel, the first thing WebVideoFullscreenInterfaceMac
should do is query for it's playbackRate() and isPlaying() properties.

• platform/mac/WebVideoFullscreenInterfaceMac.mm:

(WebCore::WebVideoFullscreenInterfaceMac::WebVideoFullscreenInterfaceMac):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/WebVideoFullscreenInterfaceMac.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-09-28  Jer Noble  <jer.noble@apple.com>
+
+        PiP shows incorrect state of play button.
+        https://bugs.webkit.org/show_bug.cgi?id=162652
+
+        Reviewed by Eric Carlson.
+
+        After getting a new WebPlaybackSessionModel, the first thing WebVideoFullscreenInterfaceMac
+        should do is query for it's playbackRate() and isPlaying() properties.
+
+        * platform/mac/WebVideoFullscreenInterfaceMac.mm:
+        (WebCore::WebVideoFullscreenInterfaceMac::WebVideoFullscreenInterfaceMac):
+
 2016-09-28  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm

@@ -353 +353 @@
 {
     ASSERT(m_playbackSessionInterface->webPlaybackSessionModel());
-    m_playbackSessionInterface->webPlaybackSessionModel()->addClient(*this);
+    auto model = m_playbackSessionInterface->webPlaybackSessionModel();
+    model->addClient(*this);
+    [videoFullscreenInterfaceObjC() updateIsPlaying:model->isPlaying() newPlaybackRate:model->playbackRate()];
 }