Changeset 208829 in webkit

Timestamp:

Nov 16, 2016, 4:59:04 PM (9 years ago)

Author:

Chris Dumez

Message:

ScriptExecutionContext::processMessagePortMessagesSoon() should only post task when necessary
​https://bugs.webkit.org/show_bug.cgi?id=164812
<rdar://problem/29148465>

Reviewed by Geoffrey Garen.

ScriptExecutionContext::processMessagePortMessagesSoon() should only post task when necessary,
meaning when there is not already one pending.

• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):
(WebCore::ScriptExecutionContext::dispatchMessagePortEvents):

• dom/ScriptExecutionContext.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/ScriptExecutionContext.cpp (modified) (2 diffs)
• dom/ScriptExecutionContext.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-11-16  Chris Dumez  <cdumez@apple.com>
+
+        ScriptExecutionContext::processMessagePortMessagesSoon() should only post task when necessary
+        https://bugs.webkit.org/show_bug.cgi?id=164812
+        <rdar://problem/29148465>
+
+        Reviewed by Geoffrey Garen.
+
+        ScriptExecutionContext::processMessagePortMessagesSoon() should only post task when necessary,
+        meaning when there is not already one pending.
+
+        * dom/ScriptExecutionContext.cpp:
+        (WebCore::ScriptExecutionContext::processMessagePortMessagesSoon):
+        (WebCore::ScriptExecutionContext::dispatchMessagePortEvents):
+        * dom/ScriptExecutionContext.h:
+
 2016-11-16  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/dom/ScriptExecutionContext.cpp

@@ -138 +138 @@
 void ScriptExecutionContext::processMessagePortMessagesSoon()
 {
+    if (m_willProcessMessagePortMessagesSoon)
+        return;
+
+    m_willProcessMessagePortMessagesSoon = true;
     postTask([] (ScriptExecutionContext& context) {
         context.dispatchMessagePortEvents();
@@ -148 +152 @@
 
     Ref<ScriptExecutionContext> protectedThis(*this);
+    ASSERT(m_willProcessMessagePortMessagesSoon);
+    m_willProcessMessagePortMessagesSoon = false;
 
     // Make a frozen copy of the ports so we can iterate while new ones might be added or destroyed.

trunk/Source/WebCore/dom/ScriptExecutionContext.h

@@ -260 +260 @@
 
     bool m_activeDOMObjectAdditionForbidden;
+    bool m_willProcessMessagePortMessagesSoon { false };
     int m_timerNestingLevel;