Changeset 208917 in webkit

Timestamp:

Nov 18, 2016, 8:25:38 PM (9 years ago)

Author:

Chris Dumez

Message:

Unreviewed, rolling out r208837.

The bots did not show a progression

Reverted changeset:

"REGRESSION(r208082): 1% Speedometer regression on iOS"
​https://bugs.webkit.org/show_bug.cgi?id=164852
​http://trac.webkit.org/changeset/208837

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/CustomElementReactionQueue.cpp (modified) (3 diffs)
• Source/WebCore/dom/CustomElementReactionQueue.h (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-11-18  Chris Dumez  <cdumez@apple.com>
+
+        Unreviewed, rolling out r208837.
+
+        The bots did not show a progression
+
+        Reverted changeset:
+
+        "REGRESSION(r208082): 1% Speedometer regression on iOS"
+        https://bugs.webkit.org/show_bug.cgi?id=164852
+        http://trac.webkit.org/changeset/208837
+
 2016-11-18  Dean Jackson  <dino@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -972 +972 @@
 imported/blink/http/tests/security/shape-image-cors-port.html [ ImageOnlyFailure ]
 
-# Many custom Elements tests are temporarily skipped per https://webkit.org/b/164852
-fast/custom-elements/defined-pseudo-class.html [ Failure ]
-fast/custom-elements/reactions-for-indieui.html [ Failure ]
-fast/custom-elements/reactions-for-webkit-extensions.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/CustomElementRegistry.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/adopted-callback.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/attribute-changed-callback.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/connected-callbacks.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/custom-element-reaction-queue.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/disconnected-callbacks.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reaction-timing.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/Attr.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/CSSStyleDeclaration.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/ChildNode.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/DOMStringMap.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/DOMTokenList.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/Document.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/Element.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/ElementContentEditable.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLAnchorElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLOptionElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLOptionsCollection.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLOutputElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLSelectElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLTableElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLTableRowElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLTableSectionElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/HTMLTitleElement.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/NamedNodeMap.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/Node.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/ParentNode.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/Range.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/Selection.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/reactions/ShadowRoot.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/upgrading.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/upgrading/Node-cloneNode.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/upgrading/upgrading-enqueue-reactions.html [ Failure ]
-imported/w3c/web-platform-tests/custom-elements/upgrading/upgrading-parser-created-element.html [ Failure ]
-
 webkit.org/b/163636 media/modern-media-controls/media-controller/media-controller-resize.html [ Pass Failure Timeout ]
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-11-18  Chris Dumez  <cdumez@apple.com>
+
+        Unreviewed, rolling out r208837.
+
+        The bots did not show a progression
+
+        Reverted changeset:
+
+        "REGRESSION(r208082): 1% Speedometer regression on iOS"
+        https://bugs.webkit.org/show_bug.cgi?id=164852
+        http://trac.webkit.org/changeset/208837
+
 2016-11-18  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/dom/CustomElementReactionQueue.cpp

@@ -206 +206 @@
 inline void CustomElementReactionStack::ElementQueue::add(Element& element)
 {
+    RELEASE_ASSERT(!m_invoking);
     // FIXME: Avoid inserting the same element multiple times.
     m_elements.append(element);
@@ -212 +213 @@
 inline void CustomElementReactionStack::ElementQueue::invokeAll()
 {
+#if !ASSERT_DISABLED
+    RELEASE_ASSERT(!m_invoking);
+    TemporaryChange<bool> invoking(m_invoking, true);
+#endif
     Vector<Ref<Element>> elements;
     elements.swap(m_elements);
+    RELEASE_ASSERT(m_elements.isEmpty());
     for (auto& element : elements) {
         auto* queue = element->reactionQueue();
@@ -219 +225 @@
         queue->invokeAll(element.get());
     }
+    RELEASE_ASSERT(m_elements.isEmpty());
 }
 

trunk/Source/WebCore/dom/CustomElementReactionQueue.h

@@ -64 +64 @@
 public:
     CustomElementReactionStack()
+        : m_previousProcessingStack(s_currentProcessingStack)
     {
+        s_currentProcessingStack = this;
     }
 
     ~CustomElementReactionStack()
     {
+        if (UNLIKELY(m_queue))
+            processQueue();
+        s_currentProcessingStack = m_previousProcessingStack;
     }
 
@@ -85 +90 @@
     private:
         Vector<Ref<Element>> m_elements;
+        bool m_invoking { false };
     };
 
@@ -93 +99 @@
 
     ElementQueue* m_queue { nullptr };
+    CustomElementReactionStack* m_previousProcessingStack;
 
     WEBCORE_EXPORT static CustomElementReactionStack* s_currentProcessingStack;