Changeset 209402 in webkit

Timestamp:

Dec 6, 2016, 9:46:23 AM (9 years ago)

Author:

dbates@webkit.org

Message:

Remove unused InjectedBundle::overrideXSSAuditorEnabledForTestRunner()
​https://bugs.webkit.org/show_bug.cgi?id=165408

Reviewed by Alex Christensen.

InjectedBundle::overrideXSSAuditorEnabledForTestRunner() is unused. This function was only
called by WKBundleOverrideXSSAuditorEnabledForTestRunner(), which was removed in r106005.

• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideXSSAuditorEnabledForTestRunner): Deleted.

• WebProcess/InjectedBundle/InjectedBundle.h:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/InjectedBundle/InjectedBundle.cpp (modified) (1 diff)
• WebProcess/InjectedBundle/InjectedBundle.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-12-06  Daniel Bates  <dabates@apple.com>
+
+        Remove unused InjectedBundle::overrideXSSAuditorEnabledForTestRunner()
+        https://bugs.webkit.org/show_bug.cgi?id=165408
+
+        Reviewed by Alex Christensen.
+
+        InjectedBundle::overrideXSSAuditorEnabledForTestRunner() is unused. This function was only
+        called by WKBundleOverrideXSSAuditorEnabledForTestRunner(), which was removed in r106005.
+
+        * WebProcess/InjectedBundle/InjectedBundle.cpp:
+        (WebKit::InjectedBundle::overrideXSSAuditorEnabledForTestRunner): Deleted.
+        * WebProcess/InjectedBundle/InjectedBundle.h:
+
 2016-12-04  Darin Adler  <darin@apple.com>
 

trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp

@@ -269 +269 @@
 }
 
-void InjectedBundle::overrideXSSAuditorEnabledForTestRunner(WebPageGroupProxy* pageGroup, bool enabled)
-{
-    // Override the preference for all future pages.
-    WebPreferencesStore::overrideBoolValueForKey(WebPreferencesKey::xssAuditorEnabledKey(), enabled);
-
-    // Change the setting for existing ones.
-    const HashSet<Page*>& pages = PageGroup::pageGroup(pageGroup->identifier())->pages();
-    for (HashSet<Page*>::iterator iter = pages.begin(); iter != pages.end(); ++iter)
-        (*iter)->settings().setXSSAuditorEnabled(enabled);
-}
-
 void InjectedBundle::setAllowUniversalAccessFromFileURLs(WebPageGroupProxy* pageGroup, bool enabled)
 {

trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.h

@@ -100 +100 @@
     // TestRunner only SPI
     void overrideBoolPreferenceForTestRunner(WebPageGroupProxy*, const String& preference, bool enabled);
-    void overrideXSSAuditorEnabledForTestRunner(WebPageGroupProxy* pageGroup, bool enabled);
     void setAllowUniversalAccessFromFileURLs(WebPageGroupProxy*, bool);
     void setAllowFileAccessFromFileURLs(WebPageGroupProxy*, bool);