Changeset 209413 in webkit

Timestamp:

Dec 6, 2016, 1:03:43 PM (9 years ago)

Author:

msaboff@apple.com

Message:

REGRESSION(r209399): Causes crashes when dumping JIT disassembly
​https://bugs.webkit.org/show_bug.cgi?id=165483

Reviewed by Geoffrey Garen.

Fixed the RELEASE_ASSERT() to check that the 6 character string is terminated by a null
character.

• wtf/SixCharacterHash.cpp:

(WTF::sixCharacterHashStringToInteger):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/SixCharacterHash.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2016-12-06  Michael Saboff  <msaboff@apple.com>
+
+        REGRESSION(r209399): Causes crashes when dumping JIT disassembly
+        https://bugs.webkit.org/show_bug.cgi?id=165483
+
+        Reviewed by Geoffrey Garen.
+
+        Fixed the RELEASE_ASSERT() to check that the 6 character string is terminated by a null
+        character.
+
+        * wtf/SixCharacterHash.cpp:
+        (WTF::sixCharacterHashStringToInteger):
+
 2016-12-04  Darin Adler  <darin@apple.com>
 

trunk/Source/WTF/wtf/SixCharacterHash.cpp

@@ -51 +51 @@
     }
 
-    RELEASE_ASSERT(string[6]); // FIXME: Why does this need to be a RELEASE_ASSERT?
+    RELEASE_ASSERT(!string[6]); // FIXME: Why does this need to be a RELEASE_ASSERT?
 
     return hash;