Changeset 209439 in webkit

Timestamp:

Dec 6, 2016, 5:23:54 PM (9 years ago)

Author:

dino@apple.com

Message:

Apply styling to media documents with modern controls
​https://bugs.webkit.org/show_bug.cgi?id=165499
<rdar://problems/29543847>

Reviewed by Antoine Quint.

Source/WebCore:

Existing MediaDocuments got styling from the injected style
sheet, which had rules for such documents. The modern media controls
use a scoped style rule, so we can't touch the document style. Instead,
inline the style directly from MediaDocument.

Test: media/modern-media-controls/media-documents/background-color-and-centering.html

• html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

Make sure that the small test video has the correct background,
and is not anchored to the top left of the page.

• media/modern-media-controls/media-documents/background-color-and-centering-expected.html: Added.
• media/modern-media-controls/media-documents/background-color-and-centering.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/modern-media-controls/media-documents/background-color-and-centering-expected.html (added)
• LayoutTests/media/modern-media-controls/media-documents/background-color-and-centering.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/MediaDocument.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-12-06  Dean Jackson  <dino@apple.com>
+
+        Apply styling to media documents with modern controls
+        https://bugs.webkit.org/show_bug.cgi?id=165499
+        <rdar://problems/29543847>
+
+        Reviewed by Antoine Quint.
+
+        Make sure that the small test video has the correct background,
+        and is not anchored to the top left of the page.
+
+        * media/modern-media-controls/media-documents/background-color-and-centering-expected.html: Added.
+        * media/modern-media-controls/media-documents/background-color-and-centering.html: Added.
+
 2016-12-05  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-12-06  Dean Jackson  <dino@apple.com>
+
+        Apply styling to media documents with modern controls
+        https://bugs.webkit.org/show_bug.cgi?id=165499
+        <rdar://problems/29543847>
+
+        Reviewed by Antoine Quint.
+
+        Existing MediaDocuments got styling from the injected style
+        sheet, which had rules for such documents. The modern media controls
+        use a scoped style rule, so we can't touch the document style. Instead,
+        inline the style directly from MediaDocument.
+
+        Test: media/modern-media-controls/media-documents/background-color-and-centering.html
+
+        * html/MediaDocument.cpp:
+        (WebCore::MediaDocumentParser::createDocumentStructure):
+
 2016-12-06  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/html/MediaDocument.cpp

@@ -99 +99 @@
     auto metaElement = HTMLMetaElement::create(document);
     metaElement->setAttributeWithoutSynchronization(nameAttr, AtomicString("viewport", AtomicString::ConstructFromLiteral));
-    metaElement->setAttributeWithoutSynchronization(contentAttr, AtomicString("width=device-width,initial-scale=1,user-scalable=no", AtomicString::ConstructFromLiteral));
+    metaElement->setAttributeWithoutSynchronization(contentAttr, AtomicString("width=device-width,initial-scale=1", AtomicString::ConstructFromLiteral));
     headElement->appendChild(metaElement);
 #endif