Changeset 209468 in webkit

Timestamp:

Dec 7, 2016, 12:29:55 PM (9 years ago)

Author:

jer.noble@apple.com

Message:

Exiting Element Fullscreen mode loses focus on WKWebView.
​https://bugs.webkit.org/show_bug.cgi?id=165512

Reviewed by Eric Carlson.

Setting 'window.contentView.hidden = YES' will reset the first-responder (whereas
previously setting 'window.contentView.layer.hidden = YES' did not). Grab the first-
responder before doing so, so that it can be reset correctly when moving the WKWebView
back to it's original window.

• UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/mac/WKFullScreenWindowController.mm (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-12-07  Jer Noble  <jer.noble@apple.com>
+
+        Exiting Element Fullscreen mode loses focus on WKWebView.
+        https://bugs.webkit.org/show_bug.cgi?id=165512
+
+        Reviewed by Eric Carlson.
+
+        Setting 'window.contentView.hidden = YES' will reset the first-responder (whereas
+        previously setting 'window.contentView.layer.hidden = YES' did not). Grab the first-
+        responder before doing so, so that it can be reset correctly when moving the WKWebView
+        back to it's original window.
+
+        * UIProcess/mac/WKFullScreenWindowController.mm:
+        (-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
+
 2016-12-07  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm

@@ -394 +394 @@
     _fullScreenState = NotInFullScreen;
 
+    NSResponder *firstResponder = [[self window] firstResponder];
+
     // Screen updates to be re-enabled in completeFinishExitFullScreenAnimationAfterRepaint.
     NSDisableScreenUpdates();
@@ -403 +405 @@
     [[_webViewPlaceholder window] setAutodisplay:NO];
 
-    NSResponder *firstResponder = [[self window] firstResponder];
     [self _replaceView:_webViewPlaceholder.get() with:_webView];
     BEGIN_BLOCK_OBJC_EXCEPTIONS