Changeset 211123 in webkit

Timestamp:

Jan 24, 2017, 4:55:10 PM (9 years ago)

Author:

Michael Catanzaro

Message:

WKR should not confuse Miguel Gomez with Andres Gomez
​https://bugs.webkit.org/show_bug.cgi?id=167389

Reviewed by Lucas Forschler.

Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
"mAndres Gomez". Fix this.

• Scripts/webkitpy/tool/commands/newcommitbot.py:

(NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
space on each side of the email address, so expect both spaces to be there before
considering the email for replacement.

• Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/commands/newcommitbot.py (modified) (1 diff)
• Scripts/webkitpy/tool/commands/newcommitbot_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        WKR should not confuse Miguel Gomez with Andres Gomez
+        https://bugs.webkit.org/show_bug.cgi?id=167389
+
+        Reviewed by Lucas Forschler.
+
+        Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
+        "mAndres Gomez". Fix this.
+
+        * Scripts/webkitpy/tool/commands/newcommitbot.py:
+        (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
+        space on each side of the email address, so expect both spaces to be there before
+        considering the email for replacement.
+        * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
+
 2017-01-24  Matt Rajca  <mrajca@apple.com>
 

trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot.py

@@ -135 +135 @@
             else:
                 for email in contributor.emails:
-                    commit_log = commit_log.replace(email, name_with_nick)
+                    commit_log = commit_log.replace(' %s ' % email, ' %s ' % name_with_nick)
 
         lines = commit_log.split('\n')[1:-2]  # Ignore lines with ----------.

trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py

@@ -128 +128 @@
             "Vsevolod Vlasov (vsevik) rolled out r134927 and r134944 in https://trac.webkit.org/r135487 :"
             " Reverting the reverts after merging.")
+
+    # Miguel <magomez@igalia.com> is not to be confused with Andres <agomez@igalia.com>.
+    def test_email_substring_problem(self):
+        self.assertEqual(NewCommitBot._summarize_commit_log("""------------------------------------------------------------------------
+r211084 | magomez@igalia.com | 2017-01-24 10:25:31 -0600 (Tue, 24 Jan 2017) | 13 lines
+
+[GTK] Do not paint non composited content into the window when using the threaded compositor
+https://bugs.webkit.org/show_bug.cgi?id=167367
+
+Reviewed by Carlos Garcia Campos.
+
+When using the threaded compositor we need to send the non composited content for compositing as well,
+not painting it directly into the window.
+
+No new tests.
+
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::paintsIntoWindow):
+
+------------------------------------------------------------------------"""),
+            "https://trac.webkit.org/r211084 by Miguel Gomez (magomez) [GTK] Do not paint non composited content into the window when using the threaded compositor"
+            " https://webkit.org/b/167367 Reviewed by Carlos Garcia Campos (KaL).")