Changeset 213096 in webkit

Timestamp:

Feb 27, 2017, 2:54:26 PM (9 years ago)

Author:

aakash_jain@apple.com

Message:

Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
​https://bugs.webkit.org/show_bug.cgi?id=168919

Reviewed by Tim Horton.

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj: Run scripts which are run for installhdrs phase for installapi phase as well.

Source/WebKit/mac:

• Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
• migrate-headers.sh: Run the migrate-headers script for installapi phase.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebKit.xcodeproj/project.pbxproj (modified) (2 diffs)
• mac/ChangeLog (modified) (1 diff)
• mac/Configurations/WebKitLegacy.xcconfig (modified) (1 diff)
• mac/migrate-headers.sh (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-02-27  Aakash Jain  <aakash_jain@apple.com>
+
+        Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
+        https://bugs.webkit.org/show_bug.cgi?id=168919
+
+        Reviewed by Tim Horton.
+
+        * WebKit.xcodeproj/project.pbxproj: Run scripts which are run for installhdrs phase for installapi phase as well.
+
 2017-02-22  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj

@@ -3339 +3339 @@
                         runOnlyForDeploymentPostprocessing = 0;
                         shellPath = /bin/sh;
-                        shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ]; then\n    exit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-inappropriate-objc-class-names ]; then\n    ../../Tools/Scripts/check-for-inappropriate-objc-class-names DOM Web _Web || exit $?\nfi";
+                        shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ] || [ \"${ACTION}\" = \"installapi\" ]; then\n    exit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-inappropriate-objc-class-names ]; then\n    ../../Tools/Scripts/check-for-inappropriate-objc-class-names DOM Web _Web || exit $?\nfi";
                 };
                 5D0D54210E98631D0029E223 /* Check For Weak VTables and Externals */ = {
@@ -3354 +3354 @@
                         runOnlyForDeploymentPostprocessing = 0;
                         shellPath = /bin/sh;
-                        shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ]; then\n    exit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-weak-vtables-and-externals ]; then\n    ../../Tools/Scripts/check-for-weak-vtables-and-externals || exit $?\nfi";
+                        shellScript = "if [ \"${ACTION}\" = \"installhdrs\" ] || [ \"${ACTION}\" = \"installapi\" ]; then\n    exit 0;\nfi\n\nif [ -f ../../Tools/Scripts/check-for-weak-vtables-and-externals ]; then\n    ../../Tools/Scripts/check-for-weak-vtables-and-externals || exit $?\nfi";
                 };
                 5D2F7DB70C687A5A00B5B72B /* Update Info.plist with version information */ = {

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2017-02-27  Aakash Jain  <aakash_jain@apple.com>
+
+        Enable SUPPORTS_TEXT_BASED_API in WebKitLegacy for iOS
+        https://bugs.webkit.org/show_bug.cgi?id=168919
+
+        Reviewed by Tim Horton.
+
+        * Configurations/WebKitLegacy.xcconfig: Enable SUPPORTS_TEXT_BASED_API.
+        * migrate-headers.sh: Run the migrate-headers script for installapi phase.
+
 2017-02-27  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/mac/Configurations/WebKitLegacy.xcconfig

@@ -120 +120 @@
 WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_$(WK_USE_OVERRIDE_FRAMEWORKS_DIR));
 WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR_YES = "$(WK_OVERRIDE_FRAMEWORKS_DIR)";
+
+// FIXME: Enable TAPI in open source builds once <rdar://problem/24582471> is fixed in all supported SDKs.
+SUPPORTS_TEXT_BASED_API[sdk=iphone*] = $(USE_INTERNAL_SDK);
+OTHER_TAPI_FLAGS[sdk=iphone*] = -x objective-c++ -std=c++11 -fno-rtti;
+TAPI_VERIFY_MODE[sdk=iphone*] = Pedantic;

trunk/Source/WebKit/mac/migrate-headers.sh

@@ -33 +33 @@
 fi
 
-if [ "${ACTION}" = "build" -o "${ACTION}" = "install" -o "${ACTION}" = "installhdrs" ]; then
+if [ "${ACTION}" = "build" -o "${ACTION}" = "install" -o "${ACTION}" = "installhdrs" -o "${ACTION}" = "installapi" ]; then
     ln -sfh "${WEBCORE_PRIVATE_HEADERS_DIR}" "${BUILT_PRODUCTS_DIR}/DerivedSources/WebKitLegacy/WebCorePrivateHeaders"
     make -C mac -f "MigrateHeaders.make" -j `/usr/sbin/sysctl -n hw.activecpu`