Changeset 217312 in webkit


Ignore:
Timestamp:
May 23, 2017, 5:27:24 PM (8 years ago)
Author:
Chris Dumez
Message:

Some async tests ignore jsTestIsAsync when ported from js-test-pre.js / js-test-post.js to js-test.js
​https://bugs.webkit.org/show_bug.cgi?id=172523

Reviewed by Ryosuke Niwa.

This test used to be flaky because jsTestIsAsync was ignored. It now consistently times out.

  • fast/dom/script-charset-update.html:

Port test to js-test.js instead of js-test-pre.js / js-test-post.js now that it works.

  • fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events-expected.txt:

Rebaseline test now that it actually runs to the end.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:

Remove expectation for a test that is now skipped in root TestExpectations file.

  • resources/js-test.js:

Call testRunner.waitUntilDone() in the DOMContentLoader event listener if jsTestIsAsync is already
set then, instead of waiting for the load event listener to do so. This is needed because some
tests may decide to complete *before* the load event has fired, such as the test updated in this
patch. We still need to call testRunner.waitUntilDone() in the load event listener as well because
some tests only set jsTestIsAsync in a load event handler.

Location:
trunk/LayoutTests
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r217308 r217312  
     12017-05-23  Chris Dumez  <cdumez@apple.com>
     2
     3        Some async tests ignore jsTestIsAsync when ported from js-test-pre.js / js-test-post.js to js-test.js
     4        https://bugs.webkit.org/show_bug.cgi?id=172523
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        * TestExpectations:
     9        This test used to be flaky because jsTestIsAsync was ignored. It now consistently times out.
     10
     11        * fast/dom/script-charset-update.html:
     12        Port test to js-test.js instead of js-test-pre.js / js-test-post.js now that it works.
     13
     14        * fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events-expected.txt:
     15        Rebaseline test now that it actually runs to the end.
     16
     17        * platform/ios-wk2/TestExpectations:
     18        * platform/mac-wk2/TestExpectations:
     19        Remove expectation for a test that is now skipped in root TestExpectations file.
     20
     21        * resources/js-test.js:
     22        Call testRunner.waitUntilDone() in the DOMContentLoader event listener if jsTestIsAsync is already
     23        set then, instead of waiting for the load event listener to do so. This is needed because some
     24        tests may decide to complete *before* the load event has fired, such as the test updated in this
     25        patch. We still need to call testRunner.waitUntilDone() in the load event listener as well because
     26        some tests only set jsTestIsAsync in a load event handler.
     27
    1282017-05-23  Ryan Haddad  <ryanhaddad@apple.com>
    229

  • trunk/LayoutTests/TestExpectations

    r217305 r217312  
    140140# The test frequently times out, and is just unsuccessful at detecting incorrect behavior when it passes.
    141141webkit.org/b/72698 media/audio-garbage-collect.html [ Skip ]
     142
     143# This test times out.
     144webkit.org/b/172527 fast/mediacapturefromelement/CanvasCaptureMediaStream-request-frame-events.html [ Skip ]
    142145
    143146webkit.org/b/53990 fast/forms/search-event-delay.html [ Pass Failure ]

  • trunk/LayoutTests/fast/dom/script-charset-update.html

    r217300 r217312  
    33<head>
    44<meta charset="utf-8">
    5 <script src="../../resources/js-test-pre.js"></script>
     5<script src="../../resources/js-test.js"></script>
    66</head>
    77<body>
    … …  
    3131document.body.appendChild(s);
    3232</script>
    33 <script src="../../resources/js-test-post.js"></script>
    3433</body>
    3534</html>

  • trunk/LayoutTests/fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events-expected.txt

    r213598 r217312  
     1CONSOLE MESSAGE: line 33: Turning drawing buffer preservation for the WebGL canvas being captured
    12Exercises the potential events on CanvasCaptureMediaStream.
    23
    … …  
    89PASS track.readyState is "live"
    910PASS Plugged stream to video tag.
     11PASS Video play callback succeeded.
     12PASS Drawing to canvas.
     13PASS Video canplaythrough callback succeeded.
     14PASS successfullyParsed is true
    1015
     16TEST COMPLETE
     17

  • trunk/LayoutTests/platform/ios-wk2/TestExpectations

    r217300 r217312  
    19391939webkit.org/b/169558 fast/history/ios/history-scroll-restoration.html [ Pass Failure ]
    19401940
    1941 webkit.org/b/169719 fast/mediacapturefromelement/CanvasCaptureMediaStream-request-frame-events.html [ Pass Failure ]
    1942 
    19431941webkit.org/b/171301 [ Release ] http/tests/security/contentSecurityPolicy/1.1/module-scriptnonce-invalidnonce.html [ Pass Timeout ]
    19441942

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r217300 r217312  
    636636webkit.org/b/169640 imported/w3c/web-platform-tests/html/webappapis/scripting/events/event-handler-javascript.html [ Failure ]
    637637
    638 webkit.org/b/169719 fast/mediacapturefromelement/CanvasCaptureMediaStream-request-frame-events.html [ Pass Failure ]
    639 
    640638webkit.org/b/170203 fast/images/animated-image-different-dest-size.html [ Pass ImageOnlyFailure ]
    641639

  • trunk/LayoutTests/resources/js-test.js

    r217243 r217312  
    110110    if (!isWorker()) {
    111111        window.addEventListener('DOMContentLoaded', function() {
     112            // Call waitUntilDone() as early as possible otherwise some tests may complete before
     113            // the load event has fired.
     114            if (window.jsTestIsAsync && window.testRunner)
     115                testRunner.waitUntilDone();
     116
    112117            // Some tests set jsTestIsAsync in load event handler. Adding the listener late
    113118            // makes handleTestFinished() run after the test handles load events.
Note: See TracChangeset for help on using the changeset viewer.