Changeset 219041 in webkit

Timestamp:

Jun 30, 2017, 10:06:40 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Type token background color in debugger looks poor
​https://bugs.webkit.org/show_bug.cgi?id=174063

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-06-30
Reviewed by Devin Rousso.

• UserInterface/Views/TextEditor.css:

CodeMirror widgets do not get range styles like our (.execution-range-highlight).
Make a best effort to carry over the styles to widgets. It isn't perfect, but it
covers all common situations unless a selection ends inside the widget. The
ultimate solution would be to get the expected range styles.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TextEditor.css (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-06-30  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Type token background color in debugger looks poor
+        https://bugs.webkit.org/show_bug.cgi?id=174063
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/TextEditor.css:
+        CodeMirror widgets do not get range styles like our (.execution-range-highlight).
+        Make a best effort to carry over the styles to widgets. It isn't perfect, but it
+        covers all common situations unless a selection ends inside the widget. The
+        ultimate solution would be to get the expected range styles.
+
 2017-06-30  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.css

@@ -108 +108 @@
 }
 
-.text-editor > .CodeMirror .execution-range-highlight:not(.CodeMirror-selectedtext) {
+.text-editor > .CodeMirror .execution-range-highlight:not(.CodeMirror-selectedtext),
+.text-editor > .CodeMirror .execution-range-highlight:not(.CodeMirror-selectedtext) + .CodeMirror-widget {
     background-color: hsl(90, 30%, 82%);
 }