Changeset 219201 in webkit

Timestamp:

Jul 6, 2017, 9:49:16 AM (8 years ago)

Author:

ddkilzer@apple.com

Message:

Add release assert to explore crash for <rdar://problem/32908525>

Reviewed by Brady Eidson.

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase): Add
release assert to catch cases when the IDBBackingStore is not
deleted before the UniqueIDBDatabase is destroyed. The
IDBBackingStore should always be released on the database
thread.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indexeddb/server/UniqueIDBDatabase.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-07-06  David Kilzer  <ddkilzer@apple.com>
+
+        Add release assert to explore crash for <rdar://problem/32908525>
+
+        Reviewed by Brady Eidson.
+
+        * Modules/indexeddb/server/UniqueIDBDatabase.cpp:
+        (WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase): Add
+        release assert to catch cases when the IDBBackingStore is not
+        deleted before the UniqueIDBDatabase is destroyed.  The
+        IDBBackingStore should always be released on the database
+        thread.
+
 2017-07-06  Matt Lewis  <jlewis3@apple.com>
 

trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp

@@ -67 +67 @@
 {
     LOG(IndexedDB, "UniqueIDBDatabase::~UniqueIDBDatabase() (%p) %s", this, m_identifier.debugString().utf8().data());
+    RELEASE_ASSERT(!m_backingStore);
     ASSERT(isMainThread());
     ASSERT(!hasAnyPendingCallbacks());