Changeset 219894 in webkit

Timestamp:

Jul 25, 2017, 5:45:04 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: Fix warnings about console.assert lines without semicolons
​https://bugs.webkit.org/show_bug.cgi?id=174840

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-07-25
Reviewed by Brian Burg.

• UserInterface/Views/SettingsTabContentView.js:

(WebInspector.SettingsTabContentView.prototype.set selectedSettingsView):
(WebInspector.SettingsTabContentView.prototype.setSettingsViewVisible):
Add semicolon to assert lines so they can be stripped in optimized builds.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SettingsTabContentView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-07-25  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Fix warnings about console.assert lines without semicolons
+        https://bugs.webkit.org/show_bug.cgi?id=174840
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WebInspector.SettingsTabContentView.prototype.set selectedSettingsView):
+        (WebInspector.SettingsTabContentView.prototype.setSettingsViewVisible):
+        Add semicolon to assert lines so they can be stripped in optimized builds.
+
 2017-07-25  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

@@ -81 +81 @@
 
         let navigationItem = this._navigationBar.findNavigationItem(settingsView.identifier);
-        console.assert(navigationItem, "Missing navigation item for settings view.", settingsView)
+        console.assert(navigationItem, "Missing navigation item for settings view.", settingsView);
         if (!navigationItem)
             return;
@@ -126 +126 @@
 
         let index = this._settingsViews.indexOf(settingsView);
-        console.assert(index !== -1, "SettingsView not found.", settingsView)
+        console.assert(index !== -1, "SettingsView not found.", settingsView);
         if (index === -1)
             return;