Changeset 219972 in webkit

Timestamp:

Jul 26, 2017, 5:13:20 PM (8 years ago)

Author:

Devin Rousso

Message:

Uncaught Exception: undefined is not an object (evaluating 'this._memoryRow.value = Number.bytesToString(this._canvas.memoryCost)')
​https://bugs.webkit.org/show_bug.cgi?id=174823

Reviewed by Joseph Pecoraro.

• UserInterface/Views/CanvasDetailsSidebarPanel.js:

(WebInspector.CanvasDetailsSidebarPanel.prototype._refreshIdentitySection):
(WebInspector.CanvasDetailsSidebarPanel.prototype._refreshSourceSection):
(WebInspector.CanvasDetailsSidebarPanel.prototype._refreshAttributesSection):
(WebInspector.CanvasDetailsSidebarPanel.prototype._refreshCSSCanvasSection):
(WebInspector.CanvasDetailsSidebarPanel.prototype._formatMemoryRow):
Early return if the view has not called initialLayout, as the rows might not have been
constructed yet.

• UserInterface/Views/View.js:

(WebInspector.View.prototype.get didInitialLayout): Added.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CanvasDetailsSidebarPanel.js (modified) (5 diffs)
• UserInterface/Views/View.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-07-26  Devin Rousso  <drousso@apple.com>
+
+        Uncaught Exception: undefined is not an object (evaluating 'this._memoryRow.value = Number.bytesToString(this._canvas.memoryCost)')
+        https://bugs.webkit.org/show_bug.cgi?id=174823
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/CanvasDetailsSidebarPanel.js:
+        (WebInspector.CanvasDetailsSidebarPanel.prototype._refreshIdentitySection):
+        (WebInspector.CanvasDetailsSidebarPanel.prototype._refreshSourceSection):
+        (WebInspector.CanvasDetailsSidebarPanel.prototype._refreshAttributesSection):
+        (WebInspector.CanvasDetailsSidebarPanel.prototype._refreshCSSCanvasSection):
+        (WebInspector.CanvasDetailsSidebarPanel.prototype._formatMemoryRow):
+        Early return if the view has not called initialLayout, as the rows might not have been
+        constructed yet.
+
+        * UserInterface/Views/View.js:
+        (WebInspector.View.prototype.get didInitialLayout): Added.
+
 2017-07-26  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CanvasDetailsSidebarPanel.js

@@ -144 +144 @@
     _refreshIdentitySection()
     {
-        if (!this._canvas)
-            return;
-
         this._nameRow.value = this._canvas.displayName;
         this._typeRow.value = WebInspector.Canvas.displayNameForContextType(this._canvas.contextType);
@@ -154 +151 @@
     _refreshSourceSection()
     {
-        if (!this._canvas)
+        if (!this.didInitialLayout)
             return;
 
@@ -225 +222 @@
     _refreshAttributesSection()
     {
-        if (!this._canvas)
-            return;
-
         if (isEmptyObject(this._canvas.contextAttributes)) {
             // Remove the DataGrid to show the placeholder text.
@@ -255 +249 @@
     _refreshCSSCanvasSection()
     {
-        if (!this._canvas)
+        if (!this.didInitialLayout)
             return;
 
@@ -280 +274 @@
     _formatMemoryRow()
     {
+        if (!this.didInitialLayout)
+            return;
+
         if (!this._canvas.memoryCost || isNaN(this._canvas.memoryCost)) {
             this._memoryRow.value = emDash;

trunk/Source/WebInspectorUI/UserInterface/Views/View.js

@@ -174 +174 @@
 
     get layoutReason() { return this._layoutReason; }
+    get didInitialLayout() { return this._didInitialLayout; }
 
     didMoveToWindow(isAttachedToRoot)