Changeset 219973 in webkit

Timestamp:

Jul 26, 2017, 6:49:44 PM (8 years ago)

Author:

timothy_horton@apple.com

Message:

REGRESSION (r211160): Can't pinch to zoom unlocked encrypted PDFs in WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=174881
<rdar://problem/33556312>

Reviewed by Andy Estes.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _hidePasswordView]):
WKPasswordView saves and restores a bunch of scroll view properties, including
those relating to zoom limits. The restoration happens in -[WKPasswordView hide],
which is never called. Instead, the code added in r211160 just calls
removeFromSuperview after unlocking, never restoring the old zoom limits,
causing the then fully unlocked PDF to not be zoomable. Fix this by calling
-hide instead of -removeFromSuperview (which -hide also calls).

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/WKWebView.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-07-26  Tim Horton  <timothy_horton@apple.com>
+
+        REGRESSION (r211160): Can't pinch to zoom unlocked encrypted PDFs in WKWebView
+        https://bugs.webkit.org/show_bug.cgi?id=174881
+        <rdar://problem/33556312>
+
+        Reviewed by Andy Estes.
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _hidePasswordView]):
+        WKPasswordView saves and restores a bunch of scroll view properties, including
+        those relating to zoom limits. The restoration happens in -[WKPasswordView hide],
+        which is never called. Instead, the code added in r211160 just calls
+        removeFromSuperview after unlocking, never restoring the old zoom limits,
+        causing the then fully unlocked PDF to not be zoomable. Fix this by calling
+        -hide instead of -removeFromSuperview (which -hide also calls).
+
 2017-07-26  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm

@@ -2696 +2696 @@
 
     self._currentContentView.hidden = NO;
-    [_passwordView removeFromSuperview];
+    [_passwordView hide];
     _passwordView = nil;
 }