Changeset 222856 in webkit

Timestamp:

Oct 4, 2017, 10:34:45 AM (8 years ago)

Author:

Jonathan Bedard

Message:

webkitpy.tool.steps.steps_unittest.StepsTest.test_runtests_api is flakey
​https://bugs.webkit.org/show_bug.cgi?id=177751
<rdar://problem/34769470>

Reviewed by Daniel Bates.

Port._build_path() calls Tools/Scripts/webkit-build-directory and caches this
result. When capturing output from the MockExecutive, the first invocation of
Port._build_path() will log the running of Tools/Scripts/webkit-build-directory
but subsequent invocations will not.

• Scripts/webkitpy/tool/steps/steps_unittest.py:

(StepsTest):
(StepsTest.setUp): Cache the build path before running tests.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/steps/steps_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-10-04  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy.tool.steps.steps_unittest.StepsTest.test_runtests_api is flakey
+        https://bugs.webkit.org/show_bug.cgi?id=177751
+        <rdar://problem/34769470>
+
+        Reviewed by Daniel Bates.
+
+        Port._build_path() calls Tools/Scripts/webkit-build-directory and caches this
+        result. When capturing output from the MockExecutive, the first invocation of
+        Port._build_path() will log the running of Tools/Scripts/webkit-build-directory
+        but subsequent invocations will not.
+
+        * Scripts/webkitpy/tool/steps/steps_unittest.py:
+        (StepsTest):
+        (StepsTest.setUp): Cache the build path before running tests.
+
 2017-10-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 

trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py

@@ -39 +39 @@
 
 class StepsTest(unittest.TestCase):
+
+    def setUp(self):
+        # Port._build_path() calls Tools/Scripts/webkit-build-directory and caches the result. When capturing output,
+        # this can cause the first invocation of Port._build_path() to have more output than subsequent invocations.
+        # This may cause test flakiness when test order changes. By explicitly calling Port._build_path() before running
+        # tests in this suite, we avoid such flakiness.
+        MockTool().port_factory.get(options=self._step_options())._build_path()
+
     def _step_options(self):
         options = MockOptions()