Changeset 231171 in webkit

Timestamp:

Apr 30, 2018, 2:38:26 PM (7 years ago)

Author:

keith_miller@apple.com

Message:

Remove unneeded exception check from String.fromCharCode
​https://bugs.webkit.org/show_bug.cgi?id=185083

Reviewed by Mark Lam.

• runtime/StringConstructor.cpp:

(JSC::stringFromCharCode):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/StringConstructor.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2018-04-30  Keith Miller  <keith_miller@apple.com>
+
+        Remove unneeded exception check from String.fromCharCode
+        https://bugs.webkit.org/show_bug.cgi?id=185083
+
+        Reviewed by Mark Lam.
+
+        * runtime/StringConstructor.cpp:
+        (JSC::stringFromCharCode):
+
 2018-04-30  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/JavaScriptCore/runtime/StringConstructor.cpp

@@ -78 +78 @@
     unsigned length = exec->argumentCount();
     if (LIKELY(length == 1)) {
+        scope.release();
         unsigned code = exec->uncheckedArgument(0).toUInt32(exec);
-        RETURN_IF_EXCEPTION(scope, encodedJSValue());
-        scope.release();
+        // Not checking for an exception here is ok because jsSingleCharacterString will just fetch an unused string if there's an exception.
         return JSValue::encode(jsSingleCharacterString(exec, code));
     }