Changeset 235226 in webkit

Timestamp:

Aug 23, 2018, 9:37:02 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

JSContext Inspector: Scripts not showing up in Resources tab
​https://bugs.webkit.org/show_bug.cgi?id=188814
<rdar://problem/43576117>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-08-23
Reviewed by Brian Burg.

• UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel.prototype._addScript):
This path shouldn't apply to JSContext inspection which will
never have a pageTarget and but doesn't have a mainResource.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ResourceSidebarPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-08-23  Joseph Pecoraro  <pecoraro@apple.com>
+
+        JSContext Inspector: Scripts not showing up in Resources tab
+        https://bugs.webkit.org/show_bug.cgi?id=188814
+        <rdar://problem/43576117>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/ResourceSidebarPanel.js:
+        (WI.ResourceSidebarPanel.prototype._addScript):
+        This path shouldn't apply to JSContext inspection which will
+        never have a pageTarget and but doesn't have a mainResource.
+
 2018-08-22  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js

@@ -312 +312 @@
 
         // Target main resource.
-        if (script.target !== WI.pageTarget) {
-            if (script.isMainResource())
-                this._addTargetWithMainResource(script.target);
-            this.contentTreeOutline.disclosureButtons = true;
-            return;
+        if (WI.sharedApp.debuggableType !== WI.DebuggableType.JavaScript) {
+            if (script.target !== WI.pageTarget) {
+                if (script.isMainResource())
+                    this._addTargetWithMainResource(script.target);
+                this.contentTreeOutline.disclosureButtons = true;
+                return;
+            }            
         }