Changeset 235242 in webkit

Timestamp:

Aug 23, 2018, 1:20:15 PM (7 years ago)

Author:

Devin Rousso

Message:

Web Inspector: console.inspect(sessionStorage) first time does not show Session Storage content view if Storage tab was previously unvisited
​https://bugs.webkit.org/show_bug.cgi?id=188801

Reviewed by Matt Baker.

• UserInterface/Base/Main.js:

(WI.tabContentViewClassForRepresentedObject):
(WI._storageWasInspected):
Since the WI.StorageSidebarPanel is not created until the WI.StorageTabContentView is
created, the WI.StorageManager.Event.DOMStorageObjectWasInspected and
WI.StorageManager.Event.DatabaseWasInspected events do not reach the sidebar. We should
follow what WI._domNodeWasInspected does and additionally call WI.showRepresentedObject
on the inspected object.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Base/Main.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2018-08-23  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: `console.inspect(sessionStorage)` first time does not show Session Storage content view if Storage tab was previously unvisited
+        https://bugs.webkit.org/show_bug.cgi?id=188801
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Base/Main.js:
+        (WI.tabContentViewClassForRepresentedObject):
+        (WI._storageWasInspected):
+        Since the `WI.StorageSidebarPanel` is not created until the `WI.StorageTabContentView` is
+        created, the `WI.StorageManager.Event.DOMStorageObjectWasInspected` and
+        `WI.StorageManager.Event.DatabaseWasInspected` events do not reach the sidebar. We should
+        follow what `WI._domNodeWasInspected` does and additionally call `WI.showRepresentedObject`
+        on the inspected object.
+
 2018-08-23  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

@@ -1122 +1122 @@
         return WI.ResourcesTabContentView;
 
-    // FIXME: Move these to a Storage tab.
     if (representedObject instanceof WI.DOMStorageObject || representedObject instanceof WI.CookieStorageObject ||
         representedObject instanceof WI.DatabaseTableObject || representedObject instanceof WI.DatabaseObject ||
         representedObject instanceof WI.ApplicationCacheFrame || representedObject instanceof WI.IndexedDatabaseObjectStore ||
-        representedObject instanceof WI.IndexedDatabaseObjectStoreIndex)
-        return WI.ResourcesTabContentView;
+        representedObject instanceof WI.IndexedDatabase || representedObject instanceof WI.IndexedDatabaseObjectStoreIndex)
+        return WI.StorageTabContentView;
 
     if (representedObject instanceof WI.CanvasCollection)
@@ -1816 +1815 @@
 {
     this.showStorageTab();
+    this.showRepresentedObject(event.data.domStorage, null, {ignoreSearchTab: true});
 };