Changeset 23654 in webkit

Timestamp:

Jun 20, 2007, 2:16:26 PM (18 years ago)

Author:

justing

Message:

Reviewed by Darin.

<rdar://problem/5263541> REGRESSION (Safari 3 Beta 1): Pressing Delete doesn't delete an HTML message in Mail

Mail wasn't receiving the keyDown event because WebFrameView was blocking it.
It blocks the event and moves back/forward on Delete/Shift+Delete if the
back/forward list is enabled.

• WebView/WebFrameView.mm: (-[WebFrameView keyDown:]): Check to see if the BackForwardList is enabled. It always exists.

Location:

trunk/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebView/WebFrameView.mm (modified) (1 diff)

trunk/WebKit/ChangeLog

@@ +1 @@
+2007-06-20  Justin Garcia  <justin.garcia@apple.com>
+
+        Reviewed by Darin.
+        
+        <rdar://problem/5263541> REGRESSION (Safari 3 Beta 1): Pressing Delete doesn't delete an HTML message in Mail
+        
+        Mail wasn't receiving the keyDown event because WebFrameView was blocking it.
+        It blocks the event and moves back/forward on Delete/Shift+Delete if the
+        back/forward list is enabled.
+
+        * WebView/WebFrameView.mm:
+        (-[WebFrameView keyDown:]): Check to see if the BackForwardList is
+        enabled.  It always exists.
+
 2007-06-19  Anders Carlsson  <andersca@apple.com>
 

trunk/WebKit/WebView/WebFrameView.mm

@@ -626 +626 @@
     int index, count;
     BOOL callSuper = YES;
-    BOOL maintainsBackForwardList = core([self webFrame])->page()->backForwardList() ? YES : NO;
+    BOOL maintainsBackForwardList = core([self webFrame])->page()->backForwardList()->enabled() ? YES : NO;
     
     count = [characters length];