Changeset 240316 in webkit


Ignore:
Timestamp:
Jan 22, 2019, 6:12:08 PM (7 years ago)
Author:
Megan Gardner
Message:

Cancel Web Touches Properly so that long presses on YouTube links do not incorrectly trigger a load
​https://bugs.webkit.org/show_bug.cgi?id=193687
<rdar://problem/47056717>

Reviewed by Tim Horton.

Cancel web gestures when a long press is recognized.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _cancelWebGestureRecognizer]):
(-[WKContentView _longPressRecognized:]):

Location:
trunk/Source/WebKit
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r240311 r240316  
     12019-01-22  Megan Gardner  <megan_gardner@apple.com>
     2
     3        Cancel Web Touches Properly so that long presses on YouTube links do not incorrectly trigger a load
     4        https://bugs.webkit.org/show_bug.cgi?id=193687
     5        <rdar://problem/47056717>
     6
     7        Reviewed by Tim Horton.
     8
     9        Cancel web gestures when a long press is recognized.
     10
     11        * Platform/spi/ios/UIKitSPI.h:
     12        * UIProcess/ios/WKContentViewInteraction.mm:
     13        (-[WKContentView _cancelWebGestureRecognizer]):
     14        (-[WKContentView _longPressRecognized:]):
     15
    1162019-01-22  Alex Christensen  <achristensen@webkit.org>
    217

  • trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h

    r240288 r240316  
    759759@interface UIWebTouchEventsGestureRecognizer ()
    760760- (id)initWithTarget:(id)target action:(SEL)action touchDelegate:(id <UIWebTouchEventsGestureRecognizerDelegate>)delegate;
     761- (void)cancel;
    761762@property (nonatomic, getter=isDefaultPrevented) BOOL defaultPrevented;
    762763@property (nonatomic, readonly) BOOL inJavaScriptGesture;

  • trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

    r240288 r240316  
    13491349}
    13501350
     1351- (void)_cancelTouchEventGestureRecognizer
     1352{
     1353#if HAVE(CANCEL_WEB_TOUCH_EVENTS_GESTURE)
     1354    [_touchEventGestureRecognizer cancel];
     1355#endif
     1356}
     1357
    13511358- (void)_didScroll
    13521359{
    … …  
    19801987    ASSERT(gestureRecognizer == _longPressGestureRecognizer);
    19811988    [self _resetIsDoubleTapPending];
     1989    [self _cancelTouchEventGestureRecognizer];
    19821990
    19831991    _lastInteractionLocation = gestureRecognizer.startPoint;
Note: See TracChangeset for help on using the changeset viewer.