Changeset 247863 in webkit

Timestamp:

Jul 26, 2019, 9:08:15 AM (6 years ago)

Author:

Jonathan Bedard

Message:

Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
​https://bugs.webkit.org/show_bug.cgi?id=200127

Unreviewed follow-up fix.

• resultsdbpy/resultsdbpy/view/static/js/timeline.js:

(Dot.toString): Use self instead of this in render callback.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• resultsdbpy/resultsdbpy/view/static/js/timeline.js (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-07-26  Jonathan Bedard  <jbedard@apple.com>
+
+        Follow-up fix: results.webkit.org: Color should be the worst result, count should include all results
+        https://bugs.webkit.org/show_bug.cgi?id=200127
+
+        Unreviewed follow-up fix.
+
+        * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
+        (Dot.toString): Use self instead of this in render callback.
+
 2019-07-24  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js

@@ -205 +205 @@
         return render(`dot ${key}`, `<div class="tag" style="color:var(--boldInverseColor)">
                 ${function() {
-                    let percent = Math.ceil(this.failed / self.count * 100 - .5);
+                    let percent = Math.ceil(self.failed / self.count * 100 - .5);
                     if (percent > 0)
                         return percent;