Changeset 248025 in webkit

Timestamp:

Jul 30, 2019, 5:31:43 PM (6 years ago)

Author:

sbarati@apple.com

Message:

[WHLSL] Add a fast path for TypeNamer::insert where we've already seen the type
​https://bugs.webkit.org/show_bug.cgi?id=200284

Reviewed by Myles C. Maxfield.

This is a ~27% speedup in the WHLSL::prepare for the compute_boids test.
This optimization makes sense since my previous patch to make UnnamedType
ref counted was also a huge speedup. So the TypeNamer is seeing many
UnnamedTypes which are the same pointer value. On compute_boids, this
makes generateMetalCode ~40ms faster.

• Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.cpp:

(WebCore::WHLSL::Metal::TypeNamer::insert):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-30  Saam Barati  <sbarati@apple.com>
+
+        [WHLSL] Add a fast path for TypeNamer::insert where we've already seen the type
+        https://bugs.webkit.org/show_bug.cgi?id=200284
+
+        Reviewed by Myles C. Maxfield.
+
+        This is a ~27% speedup in the WHLSL::prepare for the compute_boids test.
+        This optimization makes sense since my previous patch to make UnnamedType
+        ref counted was also a huge speedup. So the TypeNamer is seeing many
+        UnnamedTypes which are the same pointer value. On compute_boids, this
+        makes generateMetalCode ~40ms faster.
+
+        * Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.cpp:
+        (WebCore::WHLSL::Metal::TypeNamer::insert):
+
 2019-07-29  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLTypeNamer.cpp

@@ -318 +318 @@
 BaseTypeNameNode* TypeNamer::insert(AST::UnnamedType& unnamedType, Vector<UniqueRef<BaseTypeNameNode>>& types)
 {
+    if (auto* result = m_unnamedTypeMapping.get(&unnamedType))
+        return result;
+
     Vector<UniqueRef<BaseTypeNameNode>>* vectorToInsertInto { nullptr };
     BaseTypeNameNode* parent { nullptr };