Changeset 250217 in webkit

Timestamp:

Sep 23, 2019, 2:05:16 AM (6 years ago)

Author:

Michael Catanzaro

Message:

[SOUP] Stop setting G_TLS_GNUTLS_PRIORITY
​https://bugs.webkit.org/show_bug.cgi?id=172154

Reviewed by Carlos Garcia Campos.

Nowadays, I maintain glib-networking. WebKit doesn't need to override its defaults to be
secure anymore. By overriding glib-networking's default priority, WebKit is force-reenabling
TLS 1.0 and TLS 1.1 even when glib-networking has disabled them.

• NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:

(main):

• WebProcess/EntryPoint/unix/WebProcessMain.cpp:

(main):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp (modified) (1 diff)
• WebProcess/EntryPoint/unix/WebProcessMain.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-09-23  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        [SOUP] Stop setting G_TLS_GNUTLS_PRIORITY
+        https://bugs.webkit.org/show_bug.cgi?id=172154
+
+        Reviewed by Carlos Garcia Campos.
+
+        Nowadays, I maintain glib-networking. WebKit doesn't need to override its defaults to be
+        secure anymore. By overriding glib-networking's default priority, WebKit is force-reenabling
+        TLS 1.0 and TLS 1.1 even when glib-networking has disabled them.
+
+        * NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp:
+        (main):
+        * WebProcess/EntryPoint/unix/WebProcessMain.cpp:
+        (main):
+
 2019-09-21  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WebKit/NetworkProcess/EntryPoint/unix/NetworkProcessMain.cpp

@@ -36 +36 @@
 int main(int argc, char** argv)
 {
-    // Disable SSLv3 very early because it is practically impossible to safely
-    // use setenv() when multiple threads are running, as another thread calling
-    // getenv() could cause a crash, and many functions use getenv() internally.
-    // This workaround will stop working if glib-networking switches away from
-    // GnuTLS or simply stops parsing this variable. We intentionally do not
-    // overwrite this priority string if it's already set by the user.
-    // https://bugzilla.gnome.org/show_bug.cgi?id=738633
-    // WARNING: This needs to be KEPT IN SYNC with WebProcessMain.cpp.
-    setenv("G_TLS_GNUTLS_PRIORITY", "NORMAL:%COMPAT:!VERS-SSL3.0:!ARCFOUR-128", 0);
-
 #if USE(GCRYPT)
     PAL::GCrypt::initialize();

trunk/Source/WebKit/WebProcess/EntryPoint/unix/WebProcessMain.cpp

@@ -36 +36 @@
 int main(int argc, char** argv)
 {
-    // Disable SSLv3 very early because it is practically impossible to safely
-    // use setenv() when multiple threads are running, as another thread calling
-    // getenv() could cause a crash, and many functions use getenv() internally.
-    // This workaround will stop working if glib-networking switches away from
-    // GnuTLS or simply stops parsing this variable. We intentionally do not
-    // overwrite this priority string if it's already set by the user.
-    // https://bugzilla.gnome.org/show_bug.cgi?id=738633
-    // WARNING: This needs to be KEPT IN SYNC with WebProcessMain.cpp.
-    setenv("G_TLS_GNUTLS_PRIORITY", "NORMAL:%COMPAT:!VERS-SSL3.0:!ARCFOUR-128", 0);
-
 #if USE(GCRYPT)
     PAL::GCrypt::initialize();