Changeset 252791 in webkit

Timestamp:

Nov 22, 2019, 12:06:19 PM (6 years ago)

Author:

Jonathan Bedard

Message:

run-javascriptcore-tests: Failure to determine configuration for reporting is fatal
​https://bugs.webkit.org/show_bug.cgi?id=204526

Reviewed by Aakash Jain.

• Scripts/run-javascriptcore-tests:

(configurationForUpload): Return empty hash if no configuration is available.
(uploadResults): Soft-fail upload if configuration is empty.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-javascriptcore-tests (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-11-22  Jonathan Bedard  <jbedard@apple.com>
+
+        run-javascriptcore-tests: Failure to determine configuration for reporting is fatal
+        https://bugs.webkit.org/show_bug.cgi?id=204526
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/run-javascriptcore-tests:
+        (configurationForUpload): Return empty hash if no configuration is available.
+        (uploadResults): Soft-fail upload if configuration is empty.
+
 2019-11-22  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/Scripts/run-javascriptcore-tests

@@ -421 +421 @@
         }
     } else {
-        die "Cannot determine platform\n";
+        print "Cannot determine platform\n";
+        return {};
     }
 
@@ -460 +461 @@
 
 setConfigurationProductDir(Cwd::abs_path($root)) if (defined($root));
-configurationForUpload() if (defined($report));
 
 if (defined($jsonFileName)) {
@@ -877 +877 @@
     }
 
+    my $configuration = configurationForUpload();
+    if (!keys $configuration) {
+        print "Invalid configuration, failed to upload to $report\n";
+        return 1;
+    }
+
     my %upload = (
         version => 0,
@@ -886 +892 @@
             id => determineCurrentSVNRevision(),
         }],
-        configuration => configurationForUpload(),
+        configuration => $configuration,
         test_results => {
             run_stats => {