Changeset 255466 in webkit

Timestamp:

Jan 30, 2020, 3:59:33 PM (6 years ago)

Author:

jiewen_tan@apple.com

Message:

Unreviewed, another speculative test fix after r255041

Source/WebKit:

• UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:

(WebKit::MockLocalConnection::getAttestation const):
Adds kSecAttrAccessible: kSecAttrAccessibleAfterFirstUnlock to secItem to bypass
potential error due to screen locks.

Tools:

• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::addTestKeyToKeychain):
Adds kSecAttrAccessible: kSecAttrAccessibleAfterFirstUnlock to secItem to bypass
potential error due to screen locks.

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-01-30  Jiewen Tan  <jiewen_tan@apple.com>
+
+        Unreviewed, another speculative test fix after r255041
+
+        * UIProcess/WebAuthentication/Mock/MockLocalConnection.mm:
+        (WebKit::MockLocalConnection::getAttestation const):
+        Adds kSecAttrAccessible: kSecAttrAccessibleAfterFirstUnlock to secItem to bypass
+        potential error due to screen locks.
+
 2020-01-30  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockLocalConnection.mm

@@ -103 +103 @@
             (id)kSecClass: (id)kSecClassKey,
             (id)kSecAttrLabel: (id)label,
+            (id)kSecAttrAccessible: (id)kSecAttrAccessibleAfterFirstUnlock,
 #if HAVE(DATA_PROTECTION_KEYCHAIN)
             (id)kSecUseDataProtectionKeychain: @YES

trunk/Tools/ChangeLog

@@ +1 @@
+2020-01-30  Jiewen Tan  <jiewen_tan@apple.com>
+
+        Unreviewed, another speculative test fix after r255041
+
+        * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
+        (WTR::TestController::addTestKeyToKeychain):
+        Adds kSecAttrAccessible: kSecAttrAccessibleAfterFirstUnlock to secItem to bypass
+        potential error due to screen locks.
+
 2020-01-30  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm

@@ -357 +357 @@
         (id)kSecAttrLabel: attrLabel,
         (id)kSecAttrApplicationTag: adoptNS([[NSData alloc] initWithBase64EncodedString:applicationTagBase64 options:NSDataBase64DecodingIgnoreUnknownCharacters]).get(),
+        (id)kSecAttrAccessible: (id)kSecAttrAccessibleAfterFirstUnlock,
 #if HAVE(DATA_PROTECTION_KEYCHAIN)
         (id)kSecUseDataProtectionKeychain: @YES