Changeset 256114 in webkit

Timestamp:

Feb 10, 2020, 3:21:37 AM (6 years ago)

Author:

Adrian Perez de Castro

Message:

[GTK][WebInspector] Do not make Web Inspector windows transient
​https://bugs.webkit.org/show_bug.cgi?id=207455

Reviewed by Carlos Garcia Campos.

Stop setting Web Inspector windows as transient for the window
containing the web view being inspected, to allow changing their
relative stacking order. No changes are needed for inspector windows
to continue being destroyed correctly when the corresponding web view
is destroyed because code for handling that was already present in
WebInspectorProxyGtk.cpp.

No new tests needed.

• UIProcess/Inspector/gtk/RemoteWebInspectorProxyGtk.cpp:

(WebKit::RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow):
Do not pass a parent window parameter to webkitInspectorWindowNew().

• UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateFrontendWindow): Remove code
to obtain the top level window of the WebKitWebView, which no longer
needs being passed to webkitInspectorWindowNew().

• UIProcess/Inspector/gtk/WebKitInspectorWindow.cpp:

(webkitInspectorWindowNew): Do not set the GtkWindow.transient-for
property for the Web Inspector window. Remove the parent window
parameter.

• UIProcess/Inspector/gtk/WebKitInspectorWindow.h: Remove the parent

window parameter for webkitInspectorWindowNew().

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Inspector/gtk/RemoteWebInspectorProxyGtk.cpp (modified) (1 diff)
• UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp (modified) (1 diff)
• UIProcess/Inspector/gtk/WebKitInspectorWindow.cpp (modified) (1 diff)
• UIProcess/Inspector/gtk/WebKitInspectorWindow.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-02-10  Adrian Perez de Castro  <aperez@igalia.com>
+
+        [GTK][WebInspector] Do not make Web Inspector windows transient
+        https://bugs.webkit.org/show_bug.cgi?id=207455
+
+        Reviewed by Carlos Garcia Campos.
+
+        Stop setting Web Inspector windows as transient for the window
+        containing the web view being inspected, to allow changing their
+        relative stacking order. No changes are needed for inspector windows
+        to continue being destroyed correctly when the corresponding web view
+        is destroyed because code for handling that was already present in
+        WebInspectorProxyGtk.cpp.
+
+        No new tests needed.
+
+        * UIProcess/Inspector/gtk/RemoteWebInspectorProxyGtk.cpp:
+        (WebKit::RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow):
+        Do not pass a parent window parameter to webkitInspectorWindowNew().
+        * UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp:
+        (WebKit::WebInspectorProxy::platformCreateFrontendWindow): Remove code
+        to obtain the top level window of the WebKitWebView, which no longer
+        needs being passed to webkitInspectorWindowNew().
+        * UIProcess/Inspector/gtk/WebKitInspectorWindow.cpp:
+        (webkitInspectorWindowNew): Do not set the GtkWindow.transient-for
+        property for the Web Inspector window. Remove the parent window
+        parameter.
+        * UIProcess/Inspector/gtk/WebKitInspectorWindow.h: Remove the parent
+        window parameter for webkitInspectorWindowNew().
+
 2020-02-10  Enrique Ocaña González  <eocanha@igalia.com>
 

trunk/Source/WebKit/UIProcess/Inspector/gtk/RemoteWebInspectorProxyGtk.cpp

@@ -72 +72 @@
     g_object_add_weak_pointer(G_OBJECT(m_webView), reinterpret_cast<void**>(&m_webView));
 
-    m_window = webkitInspectorWindowNew(nullptr);
+    m_window = webkitInspectorWindowNew();
     gtk_container_add(GTK_CONTAINER(m_window), m_webView);
     gtk_widget_show(m_webView);

trunk/Source/WebKit/UIProcess/Inspector/gtk/WebInspectorProxyGtk.cpp

@@ -262 +262 @@
         return;
 
-    GtkWidget* inspectedViewParent = gtk_widget_get_toplevel(inspectedPage()->viewWidget());
-    if (!WebCore::widgetIsOnscreenToplevelWindow(inspectedViewParent))
-        inspectedViewParent = nullptr;
-
     ASSERT(!m_inspectorWindow);
-    m_inspectorWindow = webkitInspectorWindowNew(inspectedViewParent ? GTK_WINDOW(inspectedViewParent) : nullptr);
+    m_inspectorWindow = webkitInspectorWindowNew();
     gtk_container_add(GTK_CONTAINER(m_inspectorWindow), m_inspectorView);
     gtk_widget_show(m_inspectorView);

trunk/Source/WebKit/UIProcess/Inspector/gtk/WebKitInspectorWindow.cpp

@@ -58 +58 @@
 }
 
-GtkWidget* webkitInspectorWindowNew(GtkWindow* parent)
+GtkWidget* webkitInspectorWindowNew()
 {
-    return GTK_WIDGET(g_object_new(WEBKIT_TYPE_INSPECTOR_WINDOW, "type", GTK_WINDOW_TOPLEVEL, "transient-for", parent,
+    return GTK_WIDGET(g_object_new(WEBKIT_TYPE_INSPECTOR_WINDOW, "type", GTK_WINDOW_TOPLEVEL,
         "default-width", WebInspectorProxy::initialWindowWidth, "default-height", WebInspectorProxy::initialWindowHeight, nullptr));
 }

trunk/Source/WebKit/UIProcess/Inspector/gtk/WebKitInspectorWindow.h

@@ -42 +42 @@
 GType webkit_inspector_window_get_type(void);
 
-GtkWidget* webkitInspectorWindowNew(GtkWindow* parent);
+GtkWidget* webkitInspectorWindowNew();
 void webkitInspectorWindowSetSubtitle(WebKitInspectorWindow*, const char* subtitle);