Changeset 257959 in webkit

Timestamp:

Mar 5, 2020, 4:46:58 PM (5 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: AXI: can't leave Styles and Computed panels by pressing Tab
​https://bugs.webkit.org/show_bug.cgi?id=208549
<rdar://problem/60020149>

Reviewed by Devin Rousso.

Remove focus cycling inside of the Styles and Computed panels.

• UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:

(WI.GeneralStyleDetailsSidebarPanel.prototype._handleForcedPseudoClassCheckboxKeydown):
(WI.GeneralStyleDetailsSidebarPanel.prototype._handleFilterBarInputFieldKeyDown):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/GeneralStyleDetailsSidebarPanel.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-03-05  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: AXI: can't leave Styles and Computed panels by pressing Tab
+        https://bugs.webkit.org/show_bug.cgi?id=208549
+        <rdar://problem/60020149>
+
+        Reviewed by Devin Rousso.
+
+        Remove focus cycling inside of the Styles and Computed panels.
+
+        * UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:
+        (WI.GeneralStyleDetailsSidebarPanel.prototype._handleForcedPseudoClassCheckboxKeydown):
+        (WI.GeneralStyleDetailsSidebarPanel.prototype._handleFilterBarInputFieldKeyDown):
+
 2020-03-04  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js

@@ -237 +237 @@
     _handleForcedPseudoClassCheckboxKeydown(pseudoClass, event)
     {
-        if (event.key !== "Tab")
-            return;
-
-        let pseudoClasses = WI.CSSManager.ForceablePseudoClasses;
-        let index = pseudoClasses.indexOf(pseudoClass);
-        if (event.shiftKey) {
-            if (index > 0) {
-                this._forcedPseudoClassCheckboxes[pseudoClasses[index - 1]].focus();
-                event.preventDefault();
-            } else {
-                this._filterBar.inputField.focus();
-                event.preventDefault();
-            }
-        } else {
-            if (index < pseudoClasses.length - 1) {
-                this._forcedPseudoClassCheckboxes[pseudoClasses[index + 1]].focus();
-                event.preventDefault();
-            } else if (this._panel.focusFirstSection) {
+        if (event.key !== "Tab" || event.shiftKey)
+            return;
+
+        if (WI.CSSManager.ForceablePseudoClasses.lastValue === pseudoClass) {
+            // Last checkbox is currently focused.
+            if (this._panel.focusFirstSection) {
                 this._panel.focusFirstSection();
                 event.preventDefault();
@@ -426 +414 @@
     _handleFilterBarInputFieldKeyDown(event)
     {
-        if (event.key !== "Tab")
-            return;
-
-        if (event.shiftKey) {
-            if (this._panel.focusLastSection) {
-                this._panel.focusLastSection();
-                event.preventDefault();
-            }
-        } else {
-            this._forcedPseudoClassCheckboxes[WI.CSSManager.ForceablePseudoClasses[0]].focus();
+        if (event.key !== "Tab" || !event.shiftKey)
+            return;
+
+        if (this._panel.focusLastSection) {
+            this._panel.focusLastSection();
             event.preventDefault();
         }