Changeset 258217 in webkit

Timestamp:

Mar 10, 2020, 10:44:33 AM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews] Add unit tests for commit queue factory
​https://bugs.webkit.org/show_bug.cgi?id=208862

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/factories_unittest.py:

(TestCommitQueueFactory):
(TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/factories_unittest.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/factories_unittest.py

@@ -173 +173 @@
             _BuildStepFactory(steps.SetBuildSummary),
         ])
+
+
+class TestCommitQueueFactory(TestCase):
+    def test_commit_queue_factory(self):
+        factory = factories.CommitQueueFactory(platform='mac-mojave', configuration='release', architectures=["x86_64"])
+        self.assertBuildSteps(factory.steps, [
+            _BuildStepFactory(steps.ConfigureBuild, platform='mac-mojave', configuration='release', architectures=["x86_64"], buildOnly=False, triggers=None, remotes=None, additionalArguments=None),
+            _BuildStepFactory(steps.ValidatePatch, verifycqplus=True),
+            _BuildStepFactory(steps.ValidateCommiterAndReviewer),
+            _BuildStepFactory(steps.PrintConfiguration),
+            _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.UpdateWorkingDirectory),
+            _BuildStepFactory(steps.ApplyPatch),
+            _BuildStepFactory(steps.ValidateChangeLogAndReviewer),
+            _BuildStepFactory(steps.KillOldProcesses),
+            _BuildStepFactory(steps.CompileWebKit, skipUpload=True),
+            _BuildStepFactory(steps.KillOldProcesses),
+            _BuildStepFactory(steps.ValidatePatch, addURLs=False, verifycqplus=True),
+            _BuildStepFactory(steps.RunWebKitTests),
+            _BuildStepFactory(steps.ValidatePatch, addURLs=False, verifycqplus=True),
+            _BuildStepFactory(steps.CheckOutSource),
+            _BuildStepFactory(steps.UpdateWorkingDirectory),
+            _BuildStepFactory(steps.ApplyPatch),
+            _BuildStepFactory(steps.FindModifiedChangeLogs),
+            _BuildStepFactory(steps.CreateLocalGITCommit),
+            _BuildStepFactory(steps.PushCommitToWebKitRepo),
+            _BuildStepFactory(steps.SetBuildSummary),
+        ])

trunk/Tools/ChangeLog

@@ +1 @@
+2020-03-10  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] Add unit tests for commit queue factory
+        https://bugs.webkit.org/show_bug.cgi?id=208862
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/factories_unittest.py:
+        (TestCommitQueueFactory):
+        (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
+
 2020-03-10  Aakash Jain  <aakash_jain@apple.com>