Changeset 259842 in webkit

Timestamp:

Apr 9, 2020, 5:40:02 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Storage: should be able to set a cookie with no value
​https://bugs.webkit.org/show_bug.cgi?id=210237

Reviewed by Timothy Hatcher.

• UserInterface/Views/CookiePopover.js:

(WI.CookiePopover.prototype.get serializedData):
Require an explicitly set name instead of falling back to the placeholder. Allow the
value to be an empty string.

(WI.CookiePopover.prototype.show):
Don't have default placeholder values for name or value for the reasons above.
Drive-by: if an existing WI.Cookie is provided, use its SameSite value.

• UserInterface/Views/CookiePopover.css: Added.

(.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"]):matches(:invalid, .invalid)): Added.
(.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"]).invalid): Deleted.
Instead of changing the text color, change the border color.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/CookiePopover.css (modified) (1 diff)
• UserInterface/Views/CookiePopover.js (modified) (5 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-04-09  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Storage: should be able to set a cookie with no value
+        https://bugs.webkit.org/show_bug.cgi?id=210237
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/CookiePopover.js:
+        (WI.CookiePopover.prototype.get serializedData):
+        Require an explicitly set `name` instead of falling back to the `placeholder`. Allow the
+        `value` to be an empty string.
+
+        (WI.CookiePopover.prototype.show):
+        Don't have default placeholder values for `name` or `value` for the reasons above.
+        Drive-by: if an existing `WI.Cookie` is provided, use its `SameSite` value.
+
+        * UserInterface/Views/CookiePopover.css: Added.
+        (.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"]):matches(:invalid, .invalid)): Added.
+        (.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"]).invalid): Deleted.
+        Instead of changing the text color, change the border color.
+
 2020-04-09  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/CookiePopover.css

@@ -57 +57 @@
 }
 
-.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"]).invalid {
-    color: var(--error-text-color);
+.popover .cookie-popover-content > table > tr > td > input:matches([type="text"], [type="datetime-local"]):matches(:invalid, .invalid) {
+    border-color: var(--error-text-color);
 }
 

trunk/Source/WebInspectorUI/UserInterface/Views/CookiePopover.js

@@ -52 +52 @@
             return null;
 
-        let name = this._nameInputElement.value || this._nameInputElement.placeholder;
+        let name = this._nameInputElement.value;
         if (!name)
-            return null;
-
-        let value = this._valueInputElement.value || this._valueInputElement.placeholder;
-        if (!value)
             return null;
 
@@ -84 +80 @@
         let data = {
             name,
-            value,
+            value: this._valueInputElement.value,
             domain,
             path,
@@ -125 +121 @@
         } else {
             let urlComponents = WI.networkManager.mainFrame.mainResource.urlComponents;
-            data.name = WI.unlocalizedString("name");
-            data.value = WI.unlocalizedString("value");
+            data.name = "";
+            data.value = "";
             data.domain = urlComponents.host;
             data.path = urlComponents.path;
@@ -181 +177 @@
 
         this._nameInputElement = createInputRow("name", WI.UIString("Name"), "text", data.name).inputElement;
+        this._nameInputElement.required = true;
 
         this._valueInputElement = createInputRow("value", WI.UIString("Value"), "text", data.value).inputElement;
@@ -203 +200 @@
         for (let sameSiteType of Object.values(WI.Cookie.SameSiteType)) {
             let optionElement = this._sameSiteSelectElement.appendChild(document.createElement("option"));
-            optionElement.textContent = sameSiteType;
-        }
+            optionElement.value = sameSiteType;
+            optionElement.textContent = WI.Cookie.displayNameForSameSiteType(sameSiteType);
+        }
+        this._sameSiteSelectElement.value = data.sameSite;
         createRow("same-site", WI.unlocalizedString("SameSite"), this._sameSiteSelectElement);