Changeset 260996 in webkit

Timestamp:

May 1, 2020, 5:23:54 AM (5 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Move focus out of the web view when tab is pressed and there isn't a next element to focus
​https://bugs.webkit.org/show_bug.cgi?id=211283

Reviewed by Adrian Perez de Castro.

Implement API::UIClient::takeFocus() that is called when WebCore wants to focus the chrome.

• UIProcess/API/glib/WebKitUIClient.cpp:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/glib/WebKitUIClient.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-05-01  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Move focus out of the web view when tab is pressed and there isn't a next element to focus
+        https://bugs.webkit.org/show_bug.cgi?id=211283
+
+        Reviewed by Adrian Perez de Castro.
+
+        Implement API::UIClient::takeFocus() that is called when WebCore wants to focus the chrome.
+
+        * UIProcess/API/glib/WebKitUIClient.cpp:
+
 2020-05-01  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp

@@ -295 +295 @@
 
 #if PLATFORM(GTK)
+    bool takeFocus(WebPageProxy* page, WKFocusDirection direction) final
+    {
+        if (!gtk_widget_has_focus(GTK_WIDGET(m_webView))) {
+            focus(page);
+            return true;
+        }
+        return gtk_widget_child_focus(gtk_widget_get_toplevel(GTK_WIDGET(m_webView)), direction == kWKFocusDirectionBackward ? GTK_DIR_TAB_BACKWARD : GTK_DIR_TAB_FORWARD);
+    }
+
+    void focus(WebPageProxy*) final
+    {
+        gtk_widget_grab_focus(GTK_WIDGET(m_webView));
+    }
+
     void printFrame(WebPageProxy&, WebFrameProxy& frame, CompletionHandler<void()>&& completionHandler) final
     {