Changeset 261400 in webkit

Timestamp:

May 8, 2020, 11:36:32 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

SIGILL @ WebCore::Shape::createRasterShape -- DOS ASAN
​https://bugs.webkit.org/show_bug.cgi?id=211539

Patch by Pinki Gyanchandani <​pgyanchandani@apple.com> on 2020-05-08
Reviewed by Simon Fraser.

Corrected the comment.

No new test needed.

• rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/shapes/Shape.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-05-08  Pinki Gyanchandani  <pgyanchandani@apple.com>
+
+        SIGILL @ WebCore::Shape::createRasterShape -- DOS ASAN
+        https://bugs.webkit.org/show_bug.cgi?id=211539
+
+        Reviewed by Simon Fraser.
+ 
+        Corrected the comment.
+
+        No new test needed.
+
+        * rendering/shapes/Shape.cpp:
+        (WebCore::Shape::createRasterShape):
+
 2020-05-08  Rob Buis  <rbuis@igalia.com>
 

trunk/Source/WebCore/rendering/shapes/Shape.cpp

@@ -200 +200 @@
     auto imageData = imageBuffer->getImageData(AlphaPremultiplication::Unpremultiplied, { IntPoint(), imageRect.size() });
     
-    // Removing the Release Assert, as we could get to a value where imageData could be nullptr. A case where
-    // ImageRect.size() is huge, imageData::create can return a nullptr because data size has overflowed.
-    // Refer rdar://problem/61793884
+    // We could get to a value where imageData could be nullptr. A case where ImageRect.size() is huge, imageData::create
+    // can return a nullptr because data size has overflowed. Refer rdar://problem/61793884
     if (!imageData || !imageData->data())
         return createShape();