Changeset 261466 in webkit

Timestamp:

May 10, 2020, 10:16:16 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Update user agent quirk for bankofamerica.com
​https://bugs.webkit.org/show_bug.cgi?id=211700

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-05-10
Reviewed by Carlos Garcia Campos.

Source/WebCore:

The Mac platform quirk isn't working anymore. The Chrome quirk works.

• platform/UserAgentQuirks.cpp:

(WebCore::urlRequiresChromeBrowser):
(WebCore::urlRequiresMacintoshPlatform):

Tools:

• TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:

(TestWebKitAPI::TEST):

Location:

trunk

Files:

• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/UserAgentQuirks.cpp (modified) (2 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-05-10  Michael Catanzaro  <mcatanzaro@gnome.org>
+
+        Update user agent quirk for bankofamerica.com
+        https://bugs.webkit.org/show_bug.cgi?id=211700
+
+        Reviewed by Carlos Garcia Campos.
+
+        The Mac platform quirk isn't working anymore. The Chrome quirk works.
+
+        * platform/UserAgentQuirks.cpp:
+        (WebCore::urlRequiresChromeBrowser):
+        (WebCore::urlRequiresMacintoshPlatform):
+
 2020-05-10  Darin Adler  <darin@apple.com>
 

trunk/Source/WebCore/platform/UserAgentQuirks.cpp

@@ -76 +76 @@
         return true;
 
+    // Bank of America shows an unsupported browser warning with WebKitGTK's
+    // standard user agent.
+    if (baseDomain == "bankofamerica.com")
+        return true;
+
+
     return false;
 }
@@ -142 +148 @@
         return true;
 
-    // Bank of America shows an unsupported browser warning with WebKitGTK's
-    // standard user agent.
-    if (baseDomain == "bankofamerica.com")
-        return true;
-
     return false;
 }

trunk/Tools/ChangeLog

@@ +1 @@
+2020-05-10  Michael Catanzaro  <mcatanzaro@gnome.org>
+
+        Update user agent quirk for bankofamerica.com
+        https://bugs.webkit.org/show_bug.cgi?id=211700
+
+        Reviewed by Carlos Garcia Campos.
+
+        * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
+        (TestWebKitAPI::TEST):
+
 2020-05-08  Darin Adler  <darin@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp

@@ -94 +94 @@
     assertUserAgentForURLHasChromeBrowserQuirk("http://typekit.net/");
     assertUserAgentForURLHasChromeBrowserQuirk("http://auth.mayohr.com/");
+    assertUserAgentForURLHasChromeBrowserQuirk("http://bankofamerica.com/");
 
     assertUserAgentForURLHasFirefoxBrowserQuirk("http://accounts.youtube.com/");
@@ -118 +119 @@
     assertUserAgentForURLHasMacPlatformQuirk("http://mail.ntu.edu.tw/");
     assertUserAgentForURLHasMacPlatformQuirk("http://exchange.tu-berlin.de/");
-    assertUserAgentForURLHasMacPlatformQuirk("http://bankofamerica.com/");
 }