Changeset 262843 in webkit

Timestamp:

Jun 10, 2020, 9:51:19 AM (5 years ago)

Author:

youenn@apple.com

Message:

BaseAudioSharedUnit does not need to restart its audio unit at resume time.
​https://bugs.webkit.org/show_bug.cgi?id=213021

Reviewed by Eric Carlson.

Removing a case that should not happen, and was guarded by ASSERT.
Keeping ASSERT to make sure we do not break this assumption.

• platform/mediastream/mac/BaseAudioSharedUnit.cpp:

(WebCore::BaseAudioSharedUnit::resume):
(WebCore::BaseAudioSharedUnit::suspend):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/mac/BaseAudioSharedUnit.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-06-10  Youenn Fablet  <youenn@apple.com>
+
+        BaseAudioSharedUnit does not need to restart its audio unit at resume time.
+        https://bugs.webkit.org/show_bug.cgi?id=213021
+
+        Reviewed by Eric Carlson.
+
+        Removing a case that should not happen, and was guarded by ASSERT.
+        Keeping ASSERT to make sure we do not break this assumption.
+
+        * platform/mediastream/mac/BaseAudioSharedUnit.cpp:
+        (WebCore::BaseAudioSharedUnit::resume):
+        (WebCore::BaseAudioSharedUnit::suspend):
+
 2020-06-10  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/platform/mediastream/mac/BaseAudioSharedUnit.cpp

@@ -178 +178 @@
 
     ASSERT(!m_producingCount);
-    if (m_producingCount) {
-        if (auto error = startUnit())
-            return error;
-    }
 
     forEachClient([](auto& client) {
@@ -202 +198 @@
         client.setMuted(true);
     });
+
+    ASSERT(!m_producingCount);
 
     return 0;