Changeset 264508 in webkit

Timestamp:

Jul 17, 2020, 7:34:39 AM (5 years ago)

Author:

jh718.park@samsung.com

Message:

Remove the build warning below and redundant spaces since r263985.
warning: redundant move in return statement [-Wredundant-move]

No new tests, no new behaviors.

• Modules/webaudio/AudioNode.h:
• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::create):
(WebCore::PannerNode::PannerNode):

• Modules/webaudio/PannerNode.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webaudio/AudioNode.h (modified) (1 diff)
• Modules/webaudio/PannerNode.cpp (modified) (2 diffs)
• Modules/webaudio/PannerNode.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-07-17  Joonghun Park  <jh718.park@samsung.com>
+
+        Remove the build warning below and redundant spaces since r263985.
+        warning: redundant move in return statement [-Wredundant-move]
+
+        No new tests, no new behaviors.
+
+        * Modules/webaudio/AudioNode.h:
+        * Modules/webaudio/PannerNode.cpp:
+        (WebCore::PannerNode::create):
+        (WebCore::PannerNode::PannerNode):
+        * Modules/webaudio/PannerNode.h:
+
 2020-07-16  Rob Buis  <rbuis@igalia.com>
 

trunk/Source/WebCore/Modules/webaudio/AudioNode.h

@@ -211 +211 @@
     NodeType m_nodeType { NodeTypeUnknown };
     Ref<BaseAudioContext> m_context;
-    
+
     // FIXME: Remove m_sampleRate once old constructor is removed.
     float m_sampleRate;
-    
+
     Vector<std::unique_ptr<AudioNodeInput>> m_inputs;
     Vector<std::unique_ptr<AudioNodeOutput>> m_outputs;

trunk/Source/WebCore/Modules/webaudio/PannerNode.cpp

@@ -98 +98 @@
     if (result.hasException())
         return result.releaseException();
-    
+
     result = panner->setRefDistance(options.refDistance);
     if (result.hasException())
         return result.releaseException();
-    
+
     result = panner->setRolloffFactor(options.rolloffFactor);
     if (result.hasException())
         return result.releaseException();
-    
+
     result = panner->setConeOuterGain(options.coneOuterGain);
     if (result.hasException())
         return result.releaseException();
-    
+
     result = panner->setChannelCount(options.channelCount.valueOr(2));
     if (result.hasException())
         return result.releaseException();
-    
+
     result = panner->setChannelCountMode(options.channelCountMode.valueOr(ChannelCountMode::ClampedMax));
     if (result.hasException())
         return result.releaseException();
-    
+
     result = panner->setChannelInterpretation(options.channelInterpretation.valueOr(ChannelInterpretation::Speakers));
     if (result.hasException())
         return result.releaseException();
-    
-    return WTFMove(panner);
+
+    return panner;
 }
 
@@ -144 +144 @@
     setConeOuterAngle(options.coneOuterAngle);
     setNodeType(NodeTypePanner);
-    
+
     addInput(makeUnique<AudioNodeInput>(this));
     addOutput(makeUnique<AudioNodeOutput>(this, 2));
-    
+
     initialize();
 }

trunk/Source/WebCore/Modules/webaudio/PannerNode.h

@@ -52 +52 @@
 
 protected:
-    
+
     // FIXME: Remove once dependencies on old constructor are removed
     PannerNodeBase(BaseAudioContext&, float sampleRate);
@@ -73 +73 @@
         return adoptRef(*new PannerNode(context, sampleRate));
     }
-    
+
     static ExceptionOr<Ref<PannerNode>> create(BaseAudioContext&, const PannerOptions& = { });
-    
+
     virtual ~PannerNode();