Changeset 266577 in webkit

Timestamp:

Sep 3, 2020, 10:19:20 PM (5 years ago)

Author:

Carlos Garcia Campos

Message:

Unreviewed. [GLIB] Add missing return

There's no change in behavior because jsObjectCall() returns undefined in case of failure, but fixes a memory leak.

• API/glib/JSCValue.cpp:

(jsc_value_object_invoke_methodv):

Location:

trunk/Source/JavaScriptCore

Files:

• API/glib/JSCValue.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Source/JavaScriptCore/API/glib/JSCValue.cpp

@@ -1011 +1011 @@
     auto result = jsObjectCall(jsContext, function, JSC::JSCCallbackFunction::Type::Method, object, arguments, &exception);
     if (jscContextHandleExceptionIfNeeded(priv->context.get(), exception))
-        jsc_value_new_undefined(priv->context.get());
+        return jsc_value_new_undefined(priv->context.get());
 
     return jscContextGetOrCreateValue(priv->context.get(), result).leakRef();

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-09-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Unreviewed. [GLIB] Add missing return
+
+        There's no change in behavior because jsObjectCall() returns undefined in case of failure, but fixes a memory leak.
+
+        * API/glib/JSCValue.cpp:
+        (jsc_value_object_invoke_methodv):
+
 2020-09-02  Yusuke Suzuki  <ysuzuki@apple.com>