Changeset 266801 in webkit


Ignore:
Timestamp:
Sep 9, 2020, 3:13:54 PM (5 years ago)
Author:
weinig@apple.com
Message:

[WebIDL] Split GlobalEventHandlers partial interface mixins out of base mixin
​https://bugs.webkit.org/show_bug.cgi?id=216316

Reviewed by Darin Adler.

Source/WebCore:

Split GlobalEventHandlersCSSAnimations.idl, GlobalEventHandlersCSSTransitions.idl and
GlobalEventHandlersPointerEvents.idl out of GlobalEventHandlers.idl to match how they
are specified more closely.

  • CMakeLists.txt:
  • DerivedSources-input.xcfilelist:
  • DerivedSources-output.xcfilelist:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/GlobalEventHandlersCSSAnimations.idl: Added.
  • animation/GlobalEventHandlersCSSTransitions.idl: Added.
  • dom/GlobalEventHandlers.idl:
  • dom/GlobalEventHandlersPointerEvents.idl: Added.

LayoutTests:

  • js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/ios-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/mac-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
  • platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:

Update for slight enumeration ordering change.

Location:
trunk
Files:
3 added
14 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r266789 r266801  
     12020-09-09  Sam Weinig  <weinig@apple.com>
     2
     3        [WebIDL] Split GlobalEventHandlers partial interface mixins out of base mixin
     4        https://bugs.webkit.org/show_bug.cgi?id=216316
     5
     6        Reviewed by Darin Adler.
     7
     8        * js/dom/dom-static-property-for-in-iteration-expected.txt:
     9        * platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
     10        * platform/ios-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
     11        * platform/mac-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt:
     12        * platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:
     13        Update for slight enumeration ordering change.
     14
    1152020-09-09  Antoine Quint  <graouts@webkit.org>
    216

  • trunk/LayoutTests/js/dom/dom-static-property-for-in-iteration-expected.txt

    r265509 r266801  
    113113PASS a["onvolumechange"] is null
    114114PASS a["onwaiting"] is null
    115 PASS a["ontransitionend"] is null
     115PASS a["onanimationstart"] is null
     116PASS a["onanimationiteration"] is null
     117PASS a["onanimationend"] is null
     118PASS a["onanimationcancel"] is null
    116119PASS a["ontransitionrun"] is null
    117120PASS a["ontransitionstart"] is null
     121PASS a["ontransitionend"] is null
    118122PASS a["ontransitioncancel"] is null
    119 PASS a["onanimationend"] is null
    120 PASS a["onanimationiteration"] is null
    121 PASS a["onanimationstart"] is null
    122 PASS a["onanimationcancel"] is null
    123123PASS a["ongotpointercapture"] is null
    124124PASS a["onlostpointercapture"] is null

  • trunk/LayoutTests/platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt

    r262537 r266801  
    116116PASS a["onvolumechange"] is null
    117117PASS a["onwaiting"] is null
    118 PASS a["ontransitionend"] is null
     118PASS a["onanimationstart"] is null
     119PASS a["onanimationiteration"] is null
     120PASS a["onanimationend"] is null
     121PASS a["onanimationcancel"] is null
    119122PASS a["ontransitionrun"] is null
    120123PASS a["ontransitionstart"] is null
     124PASS a["ontransitionend"] is null
    121125PASS a["ontransitioncancel"] is null
    122 PASS a["onanimationend"] is null
    123 PASS a["onanimationiteration"] is null
    124 PASS a["onanimationstart"] is null
    125 PASS a["onanimationcancel"] is null
    126126PASS a["ongotpointercapture"] is null
    127127PASS a["onlostpointercapture"] is null

  • trunk/LayoutTests/platform/ios-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt

    r262235 r266801  
    116116PASS a["onvolumechange"] is null
    117117PASS a["onwaiting"] is null
    118 PASS a["ontransitionend"] is null
     118PASS a["onanimationstart"] is null
     119PASS a["onanimationiteration"] is null
     120PASS a["onanimationend"] is null
     121PASS a["onanimationcancel"] is null
    119122PASS a["ontransitionrun"] is null
    120123PASS a["ontransitionstart"] is null
     124PASS a["ontransitionend"] is null
    121125PASS a["ontransitioncancel"] is null
    122 PASS a["onanimationend"] is null
    123 PASS a["onanimationiteration"] is null
    124 PASS a["onanimationstart"] is null
    125 PASS a["onanimationcancel"] is null
    126126PASS a["namespaceURI"] is http://www.w3.org/1999/xhtml
    127127PASS a["prefix"] is null

  • trunk/LayoutTests/platform/mac-wk2/js/dom/dom-static-property-for-in-iteration-expected.txt

    r265509 r266801  
    117117PASS a["onvolumechange"] is null
    118118PASS a["onwaiting"] is null
    119 PASS a["ontransitionend"] is null
     119PASS a["onanimationstart"] is null
     120PASS a["onanimationiteration"] is null
     121PASS a["onanimationend"] is null
     122PASS a["onanimationcancel"] is null
    120123PASS a["ontransitionrun"] is null
    121124PASS a["ontransitionstart"] is null
     125PASS a["ontransitionend"] is null
    122126PASS a["ontransitioncancel"] is null
    123 PASS a["onanimationend"] is null
    124 PASS a["onanimationiteration"] is null
    125 PASS a["onanimationstart"] is null
    126 PASS a["onanimationcancel"] is null
    127127PASS a["ongotpointercapture"] is null
    128128PASS a["onlostpointercapture"] is null

  • trunk/LayoutTests/platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt

    r262235 r266801  
    115115PASS a["onvolumechange"] is null
    116116PASS a["onwaiting"] is null
    117 PASS a["ontransitionend"] is null
     117PASS a["onanimationstart"] is null
     118PASS a["onanimationiteration"] is null
     119PASS a["onanimationend"] is null
     120PASS a["onanimationcancel"] is null
    118121PASS a["ontransitionrun"] is null
    119122PASS a["ontransitionstart"] is null
     123PASS a["ontransitionend"] is null
    120124PASS a["ontransitioncancel"] is null
    121 PASS a["onanimationend"] is null
    122 PASS a["onanimationiteration"] is null
    123 PASS a["onanimationstart"] is null
    124 PASS a["onanimationcancel"] is null
    125125PASS a["ongotpointercapture"] is null
    126126PASS a["onlostpointercapture"] is null

  • trunk/Source/WebCore/CMakeLists.txt

    r266753 r266801  
    648648    animation/FillMode.idl
    649649    animation/GetAnimationsOptions.idl
     650    animation/GlobalEventHandlersCSSAnimations.idl
     651    animation/GlobalEventHandlersCSSTransitions.idl
    650652    animation/IterationCompositeOperation.idl
    651653    animation/KeyframeAnimationOptions.idl
    … …  
    790792    dom/FocusEvent.idl
    791793    dom/GlobalEventHandlers.idl
     794    dom/GlobalEventHandlersPointerEvents.idl
    792795    dom/HashChangeEvent.idl
    793796    dom/IdleDeadline.idl

  • trunk/Source/WebCore/ChangeLog

    r266800 r266801  
     12020-09-09  Sam Weinig  <weinig@apple.com>
     2
     3        [WebIDL] Split GlobalEventHandlers partial interface mixins out of base mixin
     4        https://bugs.webkit.org/show_bug.cgi?id=216316
     5
     6        Reviewed by Darin Adler.
     7
     8        Split GlobalEventHandlersCSSAnimations.idl, GlobalEventHandlersCSSTransitions.idl and
     9        GlobalEventHandlersPointerEvents.idl out of GlobalEventHandlers.idl to match how they
     10        are specified more closely.
     11
     12        * CMakeLists.txt:
     13        * DerivedSources-input.xcfilelist:
     14        * DerivedSources-output.xcfilelist:
     15        * DerivedSources.make:
     16        * Sources.txt:
     17        * WebCore.xcodeproj/project.pbxproj:
     18        * animation/GlobalEventHandlersCSSAnimations.idl: Added.
     19        * animation/GlobalEventHandlersCSSTransitions.idl: Added.
     20        * dom/GlobalEventHandlers.idl:
     21        * dom/GlobalEventHandlersPointerEvents.idl: Added.
     22
    1232020-09-09  Sam Weinig  <weinig@apple.com>
    224

  • trunk/Source/WebCore/DerivedSources-input.xcfilelist

    r266753 r266801  
    542542$(PROJECT_DIR)/animation/FillMode.idl
    543543$(PROJECT_DIR)/animation/GetAnimationsOptions.idl
     544$(PROJECT_DIR)/animation/GlobalEventHandlersCSSAnimations.idl
     545$(PROJECT_DIR)/animation/GlobalEventHandlersCSSTransitions.idl
    544546$(PROJECT_DIR)/animation/IterationCompositeOperation.idl
    545547$(PROJECT_DIR)/animation/KeyframeAnimationOptions.idl
    … …  
    711713$(PROJECT_DIR)/dom/FocusEvent.idl
    712714$(PROJECT_DIR)/dom/GlobalEventHandlers.idl
     715$(PROJECT_DIR)/dom/GlobalEventHandlersPointerEvents.idl
    713716$(PROJECT_DIR)/dom/HashChangeEvent.idl
    714717$(PROJECT_DIR)/dom/IdleDeadline.idl

  • trunk/Source/WebCore/DerivedSources-output.xcfilelist

    r266753 r266801  
    777777$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSGlobalEventHandlers.cpp
    778778$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSGlobalEventHandlers.h
     779$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/GlobalEventHandlersCSSAnimations.cpp
     780$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/GlobalEventHandlersCSSAnimations.h
     781$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/GlobalEventHandlersCSSTransitions.cpp
     782$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/GlobalEventHandlersCSSTransitions.h
     783$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/GlobalEventHandlersPointerEvents.cpp
     784$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/GlobalEventHandlersPointerEvents.h
    779785$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSGlobalPerformance.cpp
    780786$(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/JSGlobalPerformance.h

  • trunk/Source/WebCore/DerivedSources.make

    r266753 r266801  
    606606    $(WebCore)/animation/FillMode.idl \
    607607    $(WebCore)/animation/GetAnimationsOptions.idl \
     608    $(WebCore)/animation/GlobalEventHandlersCSSAnimations.idl \
     609    $(WebCore)/animation/GlobalEventHandlersCSSTransitions.idl \
    608610    $(WebCore)/animation/IterationCompositeOperation.idl \
    609611    $(WebCore)/animation/KeyframeAnimationOptions.idl \
    … …  
    741743    $(WebCore)/dom/FocusEvent.idl \
    742744    $(WebCore)/dom/GlobalEventHandlers.idl \
     745    $(WebCore)/dom/GlobalEventHandlersPointerEvents.idl \
    743746    $(WebCore)/dom/HashChangeEvent.idl \
    744747    $(WebCore)/dom/IdleDeadline.idl \

  • trunk/Source/WebCore/Sources.txt

    r266698 r266801  
    29392939JSGetAnimationsOptions.cpp
    29402940JSGlobalCrypto.cpp
    2941 JSGlobalEventHandlers.cpp
    29422941JSGlobalPerformance.cpp
    29432942JSHTMLAllCollection.cpp

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r266753 r266801  
    1011610116                7C2BDD3B17C7F98B0038FF15 /* JSDOMGlobalObjectTask.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSDOMGlobalObjectTask.cpp; sourceTree = "<group>"; };
    1011710117                7C2BDD3C17C7F98B0038FF15 /* JSDOMGlobalObjectTask.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = JSDOMGlobalObjectTask.h; sourceTree = "<group>"; };
     10118                7C2D7229250838B000539662 /* GlobalEventHandlersCSSTransitions.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = GlobalEventHandlersCSSTransitions.idl; sourceTree = "<group>"; };
     10119                7C2D722C2508396300539662 /* GlobalEventHandlersCSSAnimations.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = GlobalEventHandlersCSSAnimations.idl; sourceTree = "<group>"; };
     10120                7C2D722E25083A3400539662 /* GlobalEventHandlersPointerEvents.idl */ = {isa = PBXFileReference; lastKnownFileType = text; path = GlobalEventHandlersPointerEvents.idl; sourceTree = "<group>"; };
    1011810121                7C2FA60F1EA95A3200A03108 /* ResourceCryptographicDigest.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ResourceCryptographicDigest.cpp; sourceTree = "<group>"; };
    1011910122                7C2FA6101EA95A3200A03108 /* ResourceCryptographicDigest.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ResourceCryptographicDigest.h; sourceTree = "<group>"; };
    … …  
    2183121834                                713F1D5923DF1D7D003F5EFA /* GetAnimationsOptions.h */,
    2183221835                                713F1D5723DF1D7D003F5EFA /* GetAnimationsOptions.idl */,
     21836                                7C2D722C2508396300539662 /* GlobalEventHandlersCSSAnimations.idl */,
     21837                                7C2D7229250838B000539662 /* GlobalEventHandlersCSSTransitions.idl */,
    2183321838                                71247E331FEA5F80008C08CE /* IterationCompositeOperation.h */,
    2183421839                                71247E311FEA5F7E008C08CE /* IterationCompositeOperation.idl */,
    … …  
    2931629321                                0720B09F14D3323500642955 /* GenericEventQueue.h */,
    2931729322                                7C4189AB1B07C170000FA757 /* GlobalEventHandlers.idl */,
     29323                                7C2D722E25083A3400539662 /* GlobalEventHandlersPointerEvents.idl */,
    2931829324                                E3BF19E622AF302A009C9926 /* HashChangeEvent.cpp */,
    2931929325                                2442BBF81194C9D300D49469 /* HashChangeEvent.h */,

  • trunk/Source/WebCore/dom/GlobalEventHandlers.idl

    r266678 r266801  
    11/*
    2  * Copyright (C) 2015 Apple Inc. All Rights Reserved.
     2 * Copyright (C) 2015, 2020 Apple Inc. All Rights Reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
    … …  
    9494    attribute EventHandler onwaiting;
    9595
    96     // Extensions from CSS Transitions API (https://drafts.csswg.org/css-transitions/#interface-globaleventhandlers-idl).
    97     attribute EventHandler ontransitionend;
    98     attribute EventHandler ontransitionrun;
    99     attribute EventHandler ontransitionstart;
    100     attribute EventHandler ontransitioncancel;
    101 
    102     // Event handlers from CSS Animations API (https://drafts.csswg.org/css-animations/#interface-globaleventhandlers-idl).
    103     attribute EventHandler onanimationend;
    104     attribute EventHandler onanimationiteration;
    105     attribute EventHandler onanimationstart;
    106     attribute EventHandler onanimationcancel;
    107 
    108     // Event handlers from Pointer Events API (https://w3c.github.io/pointerevents/#extensions-to-the-globaleventhandlers-mixin)
    109     attribute EventHandler ongotpointercapture;
    110     attribute EventHandler onlostpointercapture;
    111     attribute EventHandler onpointerdown;
    112     attribute EventHandler onpointermove;
    113     attribute EventHandler onpointerup;
    114     attribute EventHandler onpointercancel;
    115     attribute EventHandler onpointerover;
    116     attribute EventHandler onpointerout;
    117     attribute EventHandler onpointerenter;
    118     attribute EventHandler onpointerleave;
    119 
    12096    // Additions that are not yet part of the standard.
    12197
Note: See TracChangeset for help on using the changeset viewer.