Changeset 270710 in webkit


Ignore:
Timestamp:
Dec 11, 2020, 2:34:24 PM (5 years ago)
Author:
Brent Fulgham
Message:

Expose API for enabling/disabling Private Click Measurement
​https://bugs.webkit.org/show_bug.cgi?id=219791
<rdar://problem/70502198>

Reviewed by Alex Christensen.

Source/WebKit:

Tested by existing PCM test cases.

This patch moves the flag for enabling and disabling PCM support from the Experimental
features settings to standard settings in preparation for exposing the option in more
permanent UI. This patch does not make any changes in behavior.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _privateClickMeasurementEnabled]):
(-[WKPreferences _setPrivateClickMeasurementEnabled:]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WTF:

This patch moves the flag for enabling and disabling PCM support from the Experimental
features settings to standard settings in preparation for exposing the option in more
permanent UI. This patch does not make any changes in behavior.

  • Scripts/Preferences/WebPreferences.yaml: Add PCM flag here.
  • Scripts/Preferences/WebPreferencesExperimental.yaml: Remove PCM flag from here.
Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WTF/ChangeLog

    r270690 r270710  
     12020-12-11  Brent Fulgham  <bfulgham@apple.com>
     2
     3        Expose API for enabling/disabling Private Click Measurement
     4        https://bugs.webkit.org/show_bug.cgi?id=219791
     5        <rdar://problem/70502198>
     6
     7        Reviewed by Alex Christensen.
     8
     9        This patch moves the flag for enabling and disabling PCM support from the Experimental
     10        features settings to standard settings in preparation for exposing the option in more
     11        permanent UI. This patch does not make any changes in behavior.
     12
     13        * Scripts/Preferences/WebPreferences.yaml: Add PCM flag here.
     14        * Scripts/Preferences/WebPreferencesExperimental.yaml: Remove PCM flag from here.
     15
    1162020-12-11  Don Olmstead  <don.olmstead@sony.com>
    217

  • trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml

    r270557 r270710  
    17301730      default: false
    17311731
     1732PrivateClickMeasurementEnabled:
     1733  type: bool
     1734  humanReadableName: "Private Click Measurement"
     1735  humanReadableDescription: "Enable Private Click Measurement for Cross-Site Link Navigations"
     1736  defaultValue:
     1737    WebKitLegacy:
     1738      default: false
     1739    WebKit:
     1740      default: true
     1741    WebCore:
     1742      default: true
     1743
    17321744PunchOutWhiteBackgroundsInDarkMode:
    17331745  type: bool

  • trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml

    r270680 r270710  
    666666      default: false
    667667
    668 PrivateClickMeasurementEnabled:
    669   type: bool
    670   humanReadableName: "Private Click Measurement"
    671   humanReadableDescription: "Enable Private Click Measurement for Cross-Site Link Navigations"
    672   defaultValue:
    673     WebKitLegacy:
    674       default: false
    675     WebKit:
    676       default: true
    677     WebCore:
    678       default: true
    679 
    680668ProcessSwapOnCrossSiteNavigationEnabled:
    681669  type: bool

  • trunk/Source/WebKit/ChangeLog

    r270708 r270710  
     12020-12-11  Brent Fulgham  <bfulgham@apple.com>
     2
     3        Expose API for enabling/disabling Private Click Measurement
     4        https://bugs.webkit.org/show_bug.cgi?id=219791
     5        <rdar://problem/70502198>
     6
     7        Reviewed by Alex Christensen.
     8
     9        Tested by existing PCM test cases.
     10
     11        This patch moves the flag for enabling and disabling PCM support from the Experimental
     12        features settings to standard settings in preparation for exposing the option in more
     13        permanent UI. This patch does not make any changes in behavior.
     14
     15        * UIProcess/API/Cocoa/WKPreferences.mm:
     16        (-[WKPreferences _privateClickMeasurementEnabled]):
     17        (-[WKPreferences _setPrivateClickMeasurementEnabled:]):
     18        * UIProcess/API/Cocoa/WKPreferencesPrivate.h:
     19        * WebProcess/WebPage/WebPage.cpp:
     20        (WebKit::WebPage::updatePreferences):
     21
    1222020-12-11  Peng Liu  <peng.liu6@apple.com>
    223

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm

    r270446 r270710  
    14591459}
    14601460
     1461- (BOOL)_privateClickMeasurementEnabled
     1462{
     1463    return _preferences->privateClickMeasurementEnabled();
     1464}
     1465
     1466- (void)_setPrivateClickMeasurementEnabled:(BOOL)privateClickMeasurementEnabled
     1467{
     1468    _preferences->setPrivateClickMeasurementEnabled(privateClickMeasurementEnabled);
     1469}
     1470
    14611471@end
    14621472

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h

    r269810 r270710  
    163163@property (nonatomic, setter=_setAccessibilityIsolatedTreeEnabled:) BOOL _accessibilityIsolatedTreeEnabled WK_API_AVAILABLE(macos(10.16));
    164164@property (nonatomic, setter=_setSpeechRecognitionEnabled:) BOOL _speechRecognitionEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
     165@property (nonatomic, setter=_setPrivateClickMeasurementEnabled:) BOOL _privateClickMeasurementEnabled WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
    165166
    166167#if !TARGET_OS_IPHONE

  • trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

    r270657 r270710  
    37893789#endif
    37903790
     3791    settings.setPrivateClickMeasurementEnabled(store.getBoolValueForKey(WebPreferencesKey::privateClickMeasurementEnabledKey()));
     3792
    37913793    if (m_drawingArea)
    37923794        m_drawingArea->updatePreferences(store);
Note: See TracChangeset for help on using the changeset viewer.