Changeset 270991 in webkit

Timestamp:

Dec 18, 2020, 3:14:55 PM (5 years ago)

Author:

sbarati@apple.com

Message:

CachedRefPtr should adoptRef before calling ref to appease RefCounted's debug assertions
​https://bugs.webkit.org/show_bug.cgi?id=219953
<rdar://problem/72391255>

Reviewed by Tadeu Zagallo.

• runtime/CachedTypes.cpp:

(JSC::CachedRefPtr::decode const):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/CachedTypes.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-12-18  Saam Barati  <sbarati@apple.com>
+
+        CachedRefPtr should adoptRef before calling ref to appease RefCounted's debug assertions
+        https://bugs.webkit.org/show_bug.cgi?id=219953
+        <rdar://problem/72391255>
+
+        Reviewed by Tadeu Zagallo.
+
+        * runtime/CachedTypes.cpp:
+        (JSC::CachedRefPtr::decode const):
+
 2020-12-18  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/runtime/CachedTypes.cpp

@@ -558 +558 @@
             });
         }
-        WTF::DefaultRefDerefTraits<Source>::refIfNotNull(decodedPtr);
-        return adoptRef(decodedPtr);
+        auto result = adoptRef<Source, PtrTraits>(decodedPtr);
+        result->ref();
+        return result;
     }