Changeset 271476 in webkit

Timestamp:

Jan 13, 2021, 5:17:14 PM (5 years ago)

Author:

Andres Gonzalez

Message:

Crash ASSERT in AccessibilityRenderObject::textUnderElement during AXIsolatedObject initialization.
​https://bugs.webkit.org/show_bug.cgi?id=220446

Reviewed by Chris Fleizach.

AXIsolatedObject methods that need to forward the call to the associated
AXObject on the main thread, should call the updateBackingStore method
on the AXObject.
This fixes the issue with AccessibilityRenderObject::textUnderElement
shown in the stack trace.

• accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::associatedAXObject const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/isolatedtree/AXIsolatedObject.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-01-13  Andres Gonzalez  <andresg_22@apple.com>
+
+        Crash ASSERT in AccessibilityRenderObject::textUnderElement during AXIsolatedObject initialization.
+        https://bugs.webkit.org/show_bug.cgi?id=220446
+
+        Reviewed by Chris Fleizach.
+
+        AXIsolatedObject methods that need to forward the call to the associated
+        AXObject on the main thread, should call the updateBackingStore method
+        on the AXObject.
+        This fixes the issue with AccessibilityRenderObject::textUnderElement
+        shown in the stack trace.
+
+        * accessibility/isolatedtree/AXIsolatedObject.cpp:
+        (WebCore::AXIsolatedObject::associatedAXObject const):
+
 2021-01-13  John Wilander  <wilander@apple.com>
 

trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp

@@ -30 +30 @@
 
 #include "AXIsolatedTree.h"
+#include "AXLogger.h"
 
 #if PLATFORM(COCOA)
@@ -416 +417 @@
     ASSERT(isMainThread());
 
-    auto* axObjectCache = this->axObjectCache();
-    return axObjectCache && m_id != InvalidAXID ? axObjectCache->objectFromAXID(m_id) : nullptr;
+    if (m_id == InvalidAXID)
+        return nullptr;
+
+    if (auto* axObjectCache = this->axObjectCache()) {
+        if (auto* axObject = axObjectCache->objectFromAXID(m_id)) {
+            axObject->updateBackingStore();
+            return axObject;
+        }
+    }
+
+    return nullptr;
 }