Changeset 272013 in webkit


Ignore:
Timestamp:
Jan 28, 2021, 6:25:05 AM (5 years ago)
Author:
aboya@igalia.com
Message:

[GTK] run-gtk-tests: Ensure correct count when subtests are specified
​https://bugs.webkit.org/show_bug.cgi?id=221049

Reviewed by Adrian Perez de Castro.

Currently the code of run-gtk-tests adds the number of skipped tests
to the count of total tests. That computation failed to take into
account the case where specific subtests are run (by means of passing
the -p argument), instead of the full test suite.

This patch fixes that, only adding to "total tests" those skipped
subtests that were also specified with the -p argument when using that
mode.

  • glib/api_test_runner.py:

(TestRunner.run_tests):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r272011 r272013  
     12021-01-28  Alicia Boya García  <aboya@igalia.com>
     2
     3        [GTK] run-gtk-tests: Ensure correct count when subtests are specified
     4        https://bugs.webkit.org/show_bug.cgi?id=221049
     5
     6        Reviewed by Adrian Perez de Castro.
     7
     8        Currently the code of run-gtk-tests adds the number of skipped tests
     9        to the count of total tests. That computation failed to take into
     10        account the case where specific subtests are run (by means of passing
     11        the -p argument), instead of the full test suite.
     12
     13        This patch fixes that, only adding to "total tests" those skipped
     14        subtests that were also specified with the -p argument when using that
     15        mode.
     16
     17        * glib/api_test_runner.py:
     18        (TestRunner.run_tests):
     19
    1202021-01-28  Lauro Moura  <lmoura@igalia.com>
    221

  • trunk/Tools/glib/api_test_runner.py

    r271955 r272013  
    302302            for test in self._tests:
    303303                skipped_subtests = self._test_cases_to_skip(test)
    304                 number_of_total_tests += len(skipped_subtests)
     304                number_of_total_tests += len(skipped_subtests if not subtests else set(skipped_subtests).intersection(subtests))
    305305                results = self._run_test(test, subtests, skipped_subtests)
    306306                if len(results) == 0:
Note: See TracChangeset for help on using the changeset viewer.