Changeset 272640 in webkit


Ignore:
Timestamp:
Feb 10, 2021, 1:13:41 AM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Do not schedule update on embed creation
​https://bugs.webkit.org/show_bug.cgi?id=221375

Patch by Rob Buis <​rbuis@igalia.com> on 2021-02-10
Reviewed by Ryosuke Niwa.

Source/WebCore:

Do not schedule update on embed creation.

Test: plugins/embed-creation-crash.html

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::create):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::create):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::finishCreating): Deleted.

  • html/HTMLPlugInImageElement.h:

LayoutTests:

Add test for this.

  • plugins/embed-creation-crash-expected.txt: Added.
  • plugins/embed-creation-crash.html: Added.
Location:
trunk
Files:
2 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r272639 r272640  
     12021-02-10  Rob Buis  <rbuis@igalia.com>
     2
     3        Do not schedule update on embed creation
     4        https://bugs.webkit.org/show_bug.cgi?id=221375
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Add test for this.
     9
     10        * plugins/embed-creation-crash-expected.txt: Added.
     11        * plugins/embed-creation-crash.html: Added.
     12
    1132021-02-10  Lauro Moura  <lmoura@igalia.com>
    214

  • trunk/Source/WebCore/ChangeLog

    r272633 r272640  
     12021-02-10  Rob Buis  <rbuis@igalia.com>
     2
     3        Do not schedule update on embed creation
     4        https://bugs.webkit.org/show_bug.cgi?id=221375
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Do not schedule update on embed creation.
     9
     10        Test: plugins/embed-creation-crash.html
     11
     12        * html/HTMLEmbedElement.cpp:
     13        (WebCore::HTMLEmbedElement::create):
     14        * html/HTMLObjectElement.cpp:
     15        (WebCore::HTMLObjectElement::create):
     16        * html/HTMLPlugInImageElement.cpp:
     17        (WebCore::HTMLPlugInImageElement::finishCreating): Deleted.
     18        * html/HTMLPlugInImageElement.h:
     19
    1202021-02-09  Eric Carlson  <eric.carlson@apple.com>
    221

  • trunk/Source/WebCore/html/HTMLEmbedElement.cpp

    r257199 r272640  
    5656Ref<HTMLEmbedElement> HTMLEmbedElement::create(const QualifiedName& tagName, Document& document)
    5757{
    58     auto result = adoptRef(*new HTMLEmbedElement(tagName, document));
    59     result->finishCreating();
    60     return result;
     58    return adoptRef(*new HTMLEmbedElement(tagName, document));
    6159}
    6260

  • trunk/Source/WebCore/html/HTMLObjectElement.cpp

    r260751 r272640  
    7272Ref<HTMLObjectElement> HTMLObjectElement::create(const QualifiedName& tagName, Document& document, HTMLFormElement* form)
    7373{
    74     auto result = adoptRef(*new HTMLObjectElement(tagName, document, form));
    75     result->finishCreating();
    76     return result;
     74    return adoptRef(*new HTMLObjectElement(tagName, document, form));
    7775}
    7876

  • trunk/Source/WebCore/html/HTMLPlugInImageElement.cpp

    r272618 r272640  
    6565}
    6666
    67 void HTMLPlugInImageElement::finishCreating()
    68 {
    69     scheduleUpdateForAfterStyleResolution();
    70 }
    71 
    7267HTMLPlugInImageElement::~HTMLPlugInImageElement()
    7368{

  • trunk/Source/WebCore/html/HTMLPlugInImageElement.h

    r271650 r272640  
    4848protected:
    4949    HTMLPlugInImageElement(const QualifiedName& tagName, Document&);
    50     void finishCreating();
    5150
    5251    void didMoveToNewDocument(Document& oldDocument, Document& newDocument) override;
Note: See TracChangeset for help on using the changeset viewer.