Changeset 273030 in webkit


Ignore:
Timestamp:
Feb 17, 2021, 1:53:15 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Add deprecation notices to believed-unused commands in webkit-patch
​https://bugs.webkit.org/show_bug.cgi?id=222058

Patch by Sam Sneddon <Sam Sneddon> on 2021-02-17
Reviewed by Jonathan Bedard.

This only adds notices, asking any users of the commands to comment on
​https://bugs.webkit.org/show_bug.cgi?id=221991; it doesn't in any way break the commands,
and the deprecation is easily undone.

  • Scripts/webkitpy/tool/commands/adduserstogroups.py:
  • Scripts/webkitpy/tool/commands/analyzechangelog.py:
  • Scripts/webkitpy/tool/commands/applywatchlistlocal.py:
  • Scripts/webkitpy/tool/commands/bugfortest.py:
  • Scripts/webkitpy/tool/commands/bugsearch.py:
  • Scripts/webkitpy/tool/commands/commandtest.py:

(CommandsTest.assert_execute_outputs): Strip the warnings from unittest output to avoid changing every test
(CommandsTest._remove_deprecated_warning):

  • Scripts/webkitpy/tool/commands/deprecatedcommand.py: Added. Class decorator for Commands output notice.
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  • Scripts/webkitpy/tool/commands/findusers.py:
  • Scripts/webkitpy/tool/commands/gardenomatic.py:
  • Scripts/webkitpy/tool/commands/openbugs.py:
  • Scripts/webkitpy/tool/commands/queries.py:
  • Scripts/webkitpy/tool/commands/rebaseline.py:
  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  • Scripts/webkitpy/tool/commands/rebaselineserver.py:
  • Scripts/webkitpy/tool/commands/setupgitclone.py:
  • Scripts/webkitpy/tool/commands/suggestnominations.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run): Deprecate running tests through webkit-patch, even indirectly.

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:

(RunTestsTest.test_webkit_run_unit_tests):

  • Scripts/webkitpy/tool/steps/steps_unittest.py:

(StepsTest.test_runtests_args):

Location:
trunk/Tools
Files:
22 edited
1 copied

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r273023 r273030  
     12021-02-17  Sam Sneddon  <gsnedders@apple.com>
     2
     3        Add deprecation notices to believed-unused commands in webkit-patch
     4        https://bugs.webkit.org/show_bug.cgi?id=222058
     5
     6        Reviewed by Jonathan Bedard.
     7
     8        This only adds notices, asking any users of the commands to comment on
     9        https://bugs.webkit.org/show_bug.cgi?id=221991; it doesn't in any way break the commands,
     10        and the deprecation is easily undone.
     11
     12        * Scripts/webkitpy/tool/commands/adduserstogroups.py:
     13        * Scripts/webkitpy/tool/commands/analyzechangelog.py:
     14        * Scripts/webkitpy/tool/commands/applywatchlistlocal.py:
     15        * Scripts/webkitpy/tool/commands/bugfortest.py:
     16        * Scripts/webkitpy/tool/commands/bugsearch.py:
     17        * Scripts/webkitpy/tool/commands/commandtest.py:
     18        (CommandsTest.assert_execute_outputs): Strip the warnings from unittest output to avoid changing every test
     19        (CommandsTest._remove_deprecated_warning):
     20        * Scripts/webkitpy/tool/commands/deprecatedcommand.py: Added. Class decorator for Commands output notice.
     21        * Scripts/webkitpy/tool/commands/download.py:
     22        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
     23        * Scripts/webkitpy/tool/commands/findusers.py:
     24        * Scripts/webkitpy/tool/commands/gardenomatic.py:
     25        * Scripts/webkitpy/tool/commands/openbugs.py:
     26        * Scripts/webkitpy/tool/commands/queries.py:
     27        * Scripts/webkitpy/tool/commands/rebaseline.py:
     28        * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
     29        * Scripts/webkitpy/tool/commands/rebaselineserver.py:
     30        * Scripts/webkitpy/tool/commands/setupgitclone.py:
     31        * Scripts/webkitpy/tool/commands/suggestnominations.py:
     32        * Scripts/webkitpy/tool/commands/upload.py:
     33        * Scripts/webkitpy/tool/steps/runtests.py:
     34        (RunTests.run): Deprecate running tests through webkit-patch, even indirectly.
     35        * Scripts/webkitpy/tool/steps/runtests_unittest.py:
     36        (RunTestsTest.test_webkit_run_unit_tests):
     37        * Scripts/webkitpy/tool/steps/steps_unittest.py:
     38        (StepsTest.test_runtests_args):
     39
    1402021-02-17  Brent Fulgham  <bfulgham@apple.com>
    241

  • trunk/Tools/Scripts/webkitpy/tool/commands/adduserstogroups.py

    r225698 r273030  
    2727# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2828
     29from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
    2930from webkitpy.tool.multicommandtool import Command
    3031
    3132
     33@DeprecatedCommand
    3234class AddUsersToGroups(Command):
    3335    name = "add-users-to-groups"

  • trunk/Tools/Scripts/webkitpy/tool/commands/analyzechangelog.py

    r227427 r273030  
    3232import time
    3333
     34from webkitpy.common.checkout.changelog import ChangeLog
    3435from webkitpy.common.checkout.scm.detection import SCMDetector
    35 from webkitpy.common.checkout.changelog import ChangeLog
    3636from webkitpy.common.config.contributionareas import ContributionAreas
    3737from webkitpy.common.system.filesystem import FileSystem
     38from webkitpy.tool import steps
     39from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
    3840from webkitpy.tool.multicommandtool import Command
    39 from webkitpy.tool import steps
    40 
    41 
     41
     42
     43@DeprecatedCommand
    4244class AnalyzeChangeLog(Command):
    4345    name = "analyze-changelog"

  • trunk/Tools/Scripts/webkitpy/tool/commands/applywatchlistlocal.py

    r96540 r273030  
    2727# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2828
     29from webkitpy.tool import steps
    2930from webkitpy.tool.commands.abstractsequencedcommand import AbstractSequencedCommand
    30 from webkitpy.tool import steps
     31from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
    3132
    3233
     34@DeprecatedCommand
    3335class ApplyWatchListLocal(AbstractSequencedCommand):
    3436    name = "apply-watchlist-local"

  • trunk/Tools/Scripts/webkitpy/tool/commands/bugfortest.py

    r225698 r273030  
    2727# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2828
     29from webkitpy.tool.bot.flakytestreporter import FlakyTestReporter
     30from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
    2931from webkitpy.tool.multicommandtool import Command
    30 from webkitpy.tool.bot.flakytestreporter import FlakyTestReporter
    3132
    3233
    … …  
    3435# it could be easily expanded to auto-create bugs, etc. if another
    3536# command outside of webkitpy wanted to use it.
     37@DeprecatedCommand
    3638class BugForTest(Command):
    3739    name = "bug-for-test"

  • trunk/Tools/Scripts/webkitpy/tool/commands/bugsearch.py

    r225698 r273030  
    2727# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2828
     29from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
    2930from webkitpy.tool.multicommandtool import Command
    3031
    3132
     33@DeprecatedCommand
    3234class BugSearch(Command):
    3335    name = "bug-search"

  • trunk/Tools/Scripts/webkitpy/tool/commands/commandtest.py

    r265883 r273030  
    5757        with OutputCapture(level=logging.INFO) as captured:
    5858            command.execute(options, args, tool)
    59         self.assertEqual(captured.stdout.getvalue(), expected_stdout or '')
    60         self.assertEqual(captured.stderr.getvalue(), expected_stderr or '')
    61         self.assertEqual(captured.root.log.getvalue(), expected_logs or '')
     59
     60        actual_stdout = self._remove_deprecated_warning(captured.stdout.getvalue())
     61        actual_stderr = self._remove_deprecated_warning(captured.stderr.getvalue())
     62        actual_logs = self._remove_deprecated_warning(captured.root.log.getvalue())
     63
     64        self.assertEqual(actual_stdout, expected_stdout or '')
     65        self.assertEqual(actual_stderr, expected_stderr or '')
     66        self.assertEqual(actual_logs, expected_logs or '')
     67
     68    def _remove_deprecated_warning(self, s):
     69        lines = s.splitlines(True)  # keepends=True (PY2 doesn't accept keyword form)
     70        return "".join(l for l in lines
     71                       if "currently deprecated due to believed non-use" not in l)

  • trunk/Tools/Scripts/webkitpy/tool/commands/deprecatedcommand.py

    r273029 r273030  
    1 # Copyright (c) 2011 Google Inc. All rights reserved.
    2 # Copyright (c) 2014 Apple Inc. All rights reserved.
     1# Copyright (C) 2021 Apple Inc. All rights reserved.
    32#
    43# Redistribution and use in source and binary forms, with or without
    … …  
    1211# in the documentation and/or other materials provided with the
    1312# distribution.
    14 #     * Neither the name of Google Inc. nor the names of its
     13#     * Neither the name of Apple Inc. nor the names of its
    1514# contributors may be used to endorse or promote products derived from
    1615# this software without specific prior written permission.
    … …  
    2827# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2928
    30 from webkitpy.tool.multicommandtool import Command
    31 from webkitpy.common.config.committers import CommitterList
     29import logging
     30from functools import wraps
     31
     32_log = logging.getLogger(__name__)
    3233
    3334
    34 class FindUsers(Command):
    35     name = "find-users"
    36     help_text = "Find users matching substring"
     35def DeprecatedCommand(klass):
     36    func = klass.execute
    3737
    38     def execute(self, options, args, tool):
    39         search_string = args[0]
    40         users = CommitterList().contributors_by_search_string(search_string)
    41         for user in users:
    42             print(user)
     38    if hasattr(func, "_deprecated"):
     39        # Avoid applying this multiple times
     40        return klass
     41
     42    @wraps(func)
     43    def wrapped(self, *args, **kwargs):
     44        _log.warning("The '%s' command is currently deprecated due to believed non-use; "
     45                     "if it forms part of your workflow, please comment on "
     46                     "https://bugs.webkit.org/show_bug.cgi?id=221991 and please include the "
     47                     "command you ran, even if others have already mentioned it" % self.name)
     48        return func(self, *args, **kwargs)
     49
     50    wrapped._deprecated = True
     51
     52    klass.execute = wrapped
     53    return klass

  • trunk/Tools/Scripts/webkitpy/tool/commands/download.py

    r271158 r273030  
    3737from webkitpy.common.system.executive import ScriptError
    3838from webkitpy.tool.commands.abstractsequencedcommand import AbstractSequencedCommand
     39from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
    3940from webkitpy.tool.commands.stepsequence import StepSequence
    4041from webkitpy.tool.comments import bug_comment_from_commit_text
    … …  
    4546
    4647
     48@DeprecatedCommand
    4749class Clean(AbstractSequencedCommand):
    4850    name = "clean"
    … …  
    5658
    5759
     60@DeprecatedCommand
    5861class Update(AbstractSequencedCommand):
    5962    name = "update"
    … …  
    6568
    6669
     70@DeprecatedCommand
    6771class Build(AbstractSequencedCommand):
    6872    name = "build"
    … …  
    7882
    7983
     84@DeprecatedCommand
    8085class BuildAndTest(AbstractSequencedCommand):
    8186    name = "build-and-test"
    … …  
    8994
    9095
     96@DeprecatedCommand
    9197class CheckPatchRelevance(AbstractSequencedCommand):
    9298    name = "check-patch-relevance"
    … …  
    124130
    125131
     132@DeprecatedCommand
    126133class LandCowhand(AbstractSequencedCommand):
    127134    # Gender-blind term for cowboy, see: http://en.wiktionary.org/wiki/cowhand
    … …  
    144151
    145152
     153@DeprecatedCommand
    146154class LandCowboy(LandCowhand):
    147155    name = "land-cowboy"
    … …  
    152160
    153161
     162@DeprecatedCommand
    154163class CheckStyleLocal(AbstractSequencedCommand):
    155164    name = "check-style-local"
    … …  
    254263
    255264
     265@DeprecatedCommand
    256266class CheckStyle(AbstractPatchSequencingCommand, ProcessAttachmentsMixin):
    257267    name = "check-style"
    … …  
    266276
    267277
     278@DeprecatedCommand
    268279class BuildAttachment(AbstractPatchSequencingCommand, ProcessAttachmentsMixin):
    269280    name = "build-attachment"
    … …  
    278289
    279290
     291@DeprecatedCommand
    280292class BuildAndTestAttachment(AbstractPatchSequencingCommand, ProcessAttachmentsMixin):
    281293    name = "build-and-test-attachment"
    … …  
    318330
    319331
     332@DeprecatedCommand
    320333class ApplyWatchList(AbstractPatchSequencingCommand, ProcessAttachmentsMixin):
    321334    name = "apply-watchlist"
    … …  
    369382
    370383
     384@DeprecatedCommand
    371385class LandFromURL(AbstractPatchLandingCommand, ProcessURLsMixin):
    372386    name = "land-from-url"
    … …  
    375389
    376390
     391@DeprecatedCommand
    377392class ValidateChangelog(AbstractSequencedCommand):
    378393    name = "validate-changelog"
    … …  
    441456
    442457
     458@DeprecatedCommand
    443459class PrepareRevert(AbstractRevertPrepCommand):
    444460    name = "prepare-revert"
    … …  
    456472
    457473
     474@DeprecatedCommand
    458475class PrepareRollout(PrepareRevert):
    459476    name = "prepare-rollout"
    … …  
    464481
    465482
     483@DeprecatedCommand
    466484class CreateRevert(AbstractRevertPrepCommand):
    467485    name = "create-revert"
    … …  
    493511
    494512
     513@DeprecatedCommand
    495514class CreateRollout(CreateRevert):
    496515    name = "create-rollout"
    … …  
    524543
    525544
     545@DeprecatedCommand
    526546class Rollout(Revert):
    527547    name = "rollout"

  • trunk/Tools/Scripts/webkitpy/tool/commands/earlywarningsystem.py

    r271158 r273030  
    3535from webkitcorepy import string_utils
    3636
     37from webkitpy.common.system.executive import ScriptError
    3738from webkitpy.common.system.filesystem import FileSystem
    38 from webkitpy.common.system.executive import ScriptError
    3939from webkitpy.tool.bot.earlywarningsystemtask import EarlyWarningSystemTask, EarlyWarningSystemTaskDelegate
     40from webkitpy.tool.bot.jsctestresultsreader import JSCTestResultsReader
    4041from webkitpy.tool.bot.layouttestresultsreader import LayoutTestResultsReader
    41 from webkitpy.tool.bot.jsctestresultsreader import JSCTestResultsReader
    4242from webkitpy.tool.bot.patchanalysistask import UnableToApplyPatch, PatchIsNotValid, PatchIsNotApplicable
     43from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
    4344from webkitpy.tool.commands.queues import AbstractReviewQueue
    4445
    … …  
    4647
    4748
     49@DeprecatedCommand
    4850class AbstractEarlyWarningSystem(AbstractReviewQueue, EarlyWarningSystemTaskDelegate):
    4951    # FIXME: Switch _default_run_tests from opt-in to opt-out once more bots are ready to run tests.

  • trunk/Tools/Scripts/webkitpy/tool/commands/findusers.py

    r225698 r273030  
    2828# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2929
     30from webkitpy.common.config.committers import CommitterList
     31from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
    3032from webkitpy.tool.multicommandtool import Command
    31 from webkitpy.common.config.committers import CommitterList
    3233
    3334
     35@DeprecatedCommand
    3436class FindUsers(Command):
    3537    name = "find-users"

  • trunk/Tools/Scripts/webkitpy/tool/commands/gardenomatic.py

    r228501 r273030  
    2424
    2525from webkitpy.port import builders
     26from webkitpy.port import factory
     27from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
    2628from webkitpy.tool.commands.rebaseline import AbstractRebaseliningCommand
    2729from webkitpy.tool.servers.gardeningserver import GardeningHTTPServer
    28 from webkitpy.port import factory
    2930
    3031
     32@DeprecatedCommand
    3133class GardenOMatic(AbstractRebaseliningCommand):
    3234    name = "garden-o-matic"

  • trunk/Tools/Scripts/webkitpy/tool/commands/openbugs.py

    r202319 r273030  
    3232
    3333from webkitpy.tool.multicommandtool import Command
     34from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
    3435
    3536_log = logging.getLogger(__name__)
    3637
    3738
     39@DeprecatedCommand
    3840class OpenBugs(Command):
    3941    name = "open-bugs"

  • trunk/Tools/Scripts/webkitpy/tool/commands/queries.py

    r271244 r273030  
    4040from webkitpy.tool import steps
    4141
     42import webkitpy.common.config.urls as config_urls
    4243from webkitpy.common.checkout.commitinfo import CommitInfo
    4344from webkitpy.common.config.committers import CommitterList
    44 import webkitpy.common.config.urls as config_urls
     45from webkitpy.common.net.bugzilla import Bugzilla
    4546from webkitpy.common.net.buildbot import BuildBot
    46 from webkitpy.common.net.bugzilla import Bugzilla
    4747from webkitpy.common.net.regressionwindow import RegressionWindow
    4848from webkitpy.common.system.crashlogs import CrashLogs
    4949from webkitpy.common.system.user import User
    50 from webkitpy.tool.commands.abstractsequencedcommand import AbstractSequencedCommand
    51 from webkitpy.tool.grammar import pluralize
    52 from webkitpy.tool.multicommandtool import Command
    5350from webkitpy.layout_tests.controllers.layout_test_finder import LayoutTestFinder
    5451from webkitpy.layout_tests.models.test_expectations import TestExpectations
    5552from webkitpy.port import platform_options, configuration_options
     53from webkitpy.tool.commands.abstractsequencedcommand import AbstractSequencedCommand
     54from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
     55from webkitpy.tool.grammar import pluralize
     56from webkitpy.tool.multicommandtool import Command
    5657
    5758_log = logging.getLogger(__name__)
    5859
    5960
     61@DeprecatedCommand
    6062class SuggestReviewers(AbstractSequencedCommand):
    6163    name = "suggest-reviewers"
    … …  
    6971
    7072
     73@DeprecatedCommand
    7174class BugsToCommit(Command):
    7275    name = "bugs-to-commit"
    … …  
    8083
    8184
     85@DeprecatedCommand
    8286class PatchesInCommitQueue(Command):
    8387    name = "patches-in-commit-queue"
    … …  
    9195
    9296
     97@DeprecatedCommand
    9398class PatchesToCommitQueue(Command):
    9499    name = "patches-to-commit-queue"
    … …  
    126131
    127132
     133@DeprecatedCommand
    128134class PatchesToReview(Command):
    129135    name = "patches-to-review"
    … …  
    180186
    181187
     188@DeprecatedCommand
    182189class WhatBroke(Command):
    183190    name = "what-broke"
    … …  
    226233
    227234
     235@DeprecatedCommand
    228236class ResultsFor(Command):
    229237    name = "results-for"
    … …  
    248256
    249257
     258@DeprecatedCommand
    250259class FailureReason(Command):
    251260    name = "failure-reason"
    … …  
    344353
    345354
     355@DeprecatedCommand
    346356class FindFlakyTests(Command):
    347357    name = "find-flaky-tests"
    … …  
    413423
    414424
     425@DeprecatedCommand
    415426class TreeStatus(Command):
    416427    name = "tree-status"
    … …  
    425436
    426437
     438@DeprecatedCommand
    427439class CrashLog(Command):
    428440    name = "crash-log"
    … …  
    441453
    442454
     455@DeprecatedCommand
    443456class PrintExpectations(Command):
    444457    name = 'print-expectations'
    … …  
    530543
    531544
     545@DeprecatedCommand
    532546class PrintBaselines(Command):
    533547    name = 'print-baselines'
    … …  
    580594
    581595
     596@DeprecatedCommand
    582597class FindResolvedBugs(Command):
    583598    name = "find-resolved-bugs"

  • trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline.py

    r262709 r273030  
    3939from webkitpy.port import builders
    4040from webkitpy.port import factory
     41from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
    4142from webkitpy.tool.multicommandtool import Command
    4243
    … …  
    7576
    7677
     78@DeprecatedCommand
    7779class RebaselineTest(AbstractRebaseliningCommand):
    7880    name = "rebaseline-test-internal"
    … …  
    295297
    296298
     299@DeprecatedCommand
    297300class RebaselineJson(AbstractParallelRebaselineCommand):
    298301    name = "rebaseline-json"
    … …  
    310313
    311314
     315@DeprecatedCommand
    312316class RebaselineExpectations(AbstractParallelRebaselineCommand):
    313317    name = "rebaseline-expectations"
    … …  
    371375
    372376
     377@DeprecatedCommand
    373378class Rebaseline(AbstractParallelRebaselineCommand):
    374379    name = "rebaseline"

  • trunk/Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py

    r265883 r273030  
    330330
    331331        self.assertEqual(self.tool.filesystem.written_files, {})
    332         self.assertEqual(captured.root.log.getvalue(), 'Did not find any tests marked Rebaseline.\n')
     332        self.assertEqual(captured.root.log.getvalue(), "The 'rebaseline-expectations' command is currently deprecated due to believed non-use; if it forms part of your workflow, please comment on https://bugs.webkit.org/show_bug.cgi?id=221991 and please include the command you ran, even if others have already mentioned it\nDid not find any tests marked Rebaseline.\n")
    333333
    334334    def disabled_test_overrides_are_included_correctly(self):

  • trunk/Tools/Scripts/webkitpy/tool/commands/rebaselineserver.py

    r225698 r273030  
    3636from webkitpy.layout_tests.layout_package import json_results_generator
    3737from webkitpy.tool.commands.abstractlocalservercommand import AbstractLocalServerCommand
     38from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
    3839from webkitpy.tool.servers.rebaselineserver import get_test_baselines, RebaselineHTTPServer, STATE_NEEDS_REBASELINE
    3940
    … …  
    5051
    5152
     53@DeprecatedCommand
    5254class RebaselineServer(AbstractLocalServerCommand):
    5355    name = "rebaseline-server"

  • trunk/Tools/Scripts/webkitpy/tool/commands/setupgitclone.py

    r249752 r273030  
    2727# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2828
    29 from webkitpy.tool.multicommandtool import Command
    3029from webkitpy.common.checkout.scm.git import Git
    3130from webkitpy.common.system.executive import ScriptError
     31from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
     32from webkitpy.tool.multicommandtool import Command
    3233
    3334
     35@DeprecatedCommand
    3436class SetupGitClone(Command):
    3537    name = "setup-git-clone"

  • trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations.py

    r271158 r273030  
    3434from webkitpy.common.config.committers import CommitterList
    3535from webkitpy.tool import grammar
     36from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
    3637from webkitpy.tool.multicommandtool import Command
    3738
    … …  
    145146
    146147
     148@DeprecatedCommand
    147149class SuggestNominations(AbstractCommitLogCommand):
    148150    name = "suggest-nominations"

  • trunk/Tools/Scripts/webkitpy/tool/commands/upload.py

    r271158 r273030  
    4242from webkitpy.thirdparty.mock import Mock
    4343from webkitpy.tool.commands.abstractsequencedcommand import AbstractSequencedCommand
     44from webkitpy.tool.commands.deprecatedcommand import DeprecatedCommand
    4445from webkitpy.tool.comments import bug_comment_from_svn_revision
    4546from webkitpy.tool.grammar import pluralize, join_with_separators
    … …  
    4950
    5051
     52@DeprecatedCommand
    5153class CommitMessageForCurrentDiff(Command):
    5254    name = "commit-message"
    … …  
    6567
    6668
     69@DeprecatedCommand
    6770class CleanPendingCommit(Command):
    6871    name = "clean-pending-commit"
    … …  
    9497
    9598# FIXME: This should be share more logic with AssignToCommitter and CleanPendingCommit
     99@DeprecatedCommand
    96100class CleanReviewQueue(Command):
    97101    name = "clean-review-queue"
    … …  
    119123
    120124
     125@DeprecatedCommand
    121126class AssignToCommitter(Command):
    122127    name = "assign-to-committer"
    … …  
    162167
    163168
     169@DeprecatedCommand
    164170class ObsoleteAttachments(AbstractSequencedCommand):
    165171    name = "obsolete-attachments"
    … …  
    174180
    175181
     182@DeprecatedCommand
    176183class AttachToBug(AbstractSequencedCommand):
    177184    name = "attach-to-bug"
    … …  
    208215
    209216
     217@DeprecatedCommand
    210218class Post(AbstractPatchUploadingCommand):
    211219    name = "post"
    … …  
    242250
    243251
     252@DeprecatedCommand
    244253class HasLanded(AbstractPatchUploadingCommand):
    245254    name = "has-landed"
    … …  
    251260
    252261
     262@DeprecatedCommand
    253263class Prepare(AbstractSequencedCommand):
    254264    name = "prepare"
    … …  
    312322
    313323
     324@DeprecatedCommand
    314325class PostCommits(Command):
    315326    name = "post-commits"
    … …  
    371382
    372383# FIXME: This command needs to be brought into the modern age with steps and CommitInfo.
     384@DeprecatedCommand
    373385class MarkBugFixed(Command):
    374386    name = "mark-bug-fixed"
    … …  
    453465
    454466# FIXME: Requires unit test.  Blocking issue: too complex for now.
     467@DeprecatedCommand
    455468class CreateBug(Command):
    456469    name = "create-bug"
    … …  
    537550
    538551
     552@DeprecatedCommand
    539553class WPTChangeExport(AbstractPatchUploadingCommand):
    540554    name = "wpt-change-export"

  • trunk/Tools/Scripts/webkitpy/tool/steps/runtests.py

    r263308 r273030  
    5959
    6060    def run(self, state):
     61        if (
     62            self._options.group == "jsc"
     63            or self._options.iterate_on_new_tests
     64            or self._options.test
     65        ):
     66            _log.warning(
     67                "Running tests through webkit-patch is currently deprecated due to believed "
     68                "non-use; if it forms part of your workflow, please comment on "
     69                "https://bugs.webkit.org/show_bug.cgi?id=221991 and please include the "
     70                "command you ran, even if others have already mentioned it"
     71            )
     72
    6173        if self._options.group == "jsc":
    6274            self._run_javascriptcore_tests()

  • trunk/Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py

    r265883 r273030  
    5252            self.assertEqual(
    5353                captured.root.log.getvalue(),
    54                 '''Running run-webkit-tests
     54                '''Running tests through webkit-patch is currently deprecated due to believed non-use; if it forms part of your workflow, please comment on https://bugs.webkit.org/show_bug.cgi?id=221991 and please include the command you ran, even if others have already mentioned it
     55Running run-webkit-tests
    5556MOCK run_and_throw_if_fail: ['mock-run-webkit-tests', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures=30', '--quiet', '--skip-failing-tests'], cwd=/mock-checkout
    5657''',
    … …  
    5960            self.assertEqual(
    6061                captured.root.log.getvalue(),
    61                 '''Running run-webkit-tests
     62                '''Running tests through webkit-patch is currently deprecated due to believed non-use; if it forms part of your workflow, please comment on https://bugs.webkit.org/show_bug.cgi?id=221991 and please include the command you ran, even if others have already mentioned it
     63Running run-webkit-tests
    6264MOCK run_and_throw_if_fail: ['mock-run-webkit-tests', '--no-new-test-results', '--no-show-results', '--exit-after-n-failures=30', '--no-build'], cwd=/mock-checkout
    6365''',

  • trunk/Tools/Scripts/webkitpy/tool/steps/steps_unittest.py

    r265883 r273030  
    127127        self.assertEqual(
    128128            captured.root.log.getvalue(),
    129             '''Running Python unit tests
     129            '''Running tests through webkit-patch is currently deprecated due to believed non-use; if it forms part of your workflow, please comment on https://bugs.webkit.org/show_bug.cgi?id=221991 and please include the command you ran, even if others have already mentioned it
     130Running Python unit tests
    130131MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitpy'], cwd=/mock-checkout
    131132Running Perl unit tests
    … …  
    151152        self.assertEqual(
    152153            captured.root.log.getvalue(),
    153             '''Running Python unit tests
     154            '''Running tests through webkit-patch is currently deprecated due to believed non-use; if it forms part of your workflow, please comment on https://bugs.webkit.org/show_bug.cgi?id=221991 and please include the command you ran, even if others have already mentioned it
     155Running Python unit tests
    154156MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitpy'], cwd=/mock-checkout
    155157Running Perl unit tests
    … …  
    176178        self.assertEqual(
    177179            captured.root.log.getvalue(),
    178             "MOCK run_and_throw_if_fail: ['Tools/Scripts/run-javascriptcore-tests', '--no-fail-fast', '--release', '--json-output=/tmp/jsc_test_results.json'], cwd=/mock-checkout\n",
     180            "Running tests through webkit-patch is currently deprecated due to believed non-use; if it forms part of your workflow, please comment on https://bugs.webkit.org/show_bug.cgi?id=221991 and please include the command you ran, even if others have already mentioned it\nMOCK run_and_throw_if_fail: ['Tools/Scripts/run-javascriptcore-tests', '--no-fail-fast', '--release', '--json-output=/tmp/jsc_test_results.json'], cwd=/mock-checkout\n",
    179181        )
    180182
    … …  
    192194        self.assertEqual(
    193195            captured.root.log.getvalue(),
    194             "MOCK run_and_throw_if_fail: ['Tools/Scripts/run-javascriptcore-tests', '--no-fail-fast', '--debug', '--json-output=/tmp/jsc_test_results.json'], cwd=/mock-checkout\n",
     196            "Running tests through webkit-patch is currently deprecated due to believed non-use; if it forms part of your workflow, please comment on https://bugs.webkit.org/show_bug.cgi?id=221991 and please include the command you ran, even if others have already mentioned it\nMOCK run_and_throw_if_fail: ['Tools/Scripts/run-javascriptcore-tests', '--no-fail-fast', '--debug', '--json-output=/tmp/jsc_test_results.json'], cwd=/mock-checkout\n",
    195197        )
    196198
Note: See TracChangeset for help on using the changeset viewer.