Changeset 273515 in webkit


Ignore:
Timestamp:
Feb 25, 2021, 3:20:59 PM (4 years ago)
Author:
commit-queue@webkit.org
Message:

Add stubs to enable SafariForWebKitDevelopment to launch
​https://bugs.webkit.org/show_bug.cgi?id=222388

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-02-25
Source/JavaScriptCore:

Reviewed by Myles Maxfield.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/SymbolStubsForSafariCompatibility.mm: Added.

(WTF::String::String):
(WTF::JSONImpl::ObjectBase::getArray const):
(WTF::JSONImpl::ObjectBase::getValue const):
(WTF::JSONImpl::ObjectBase::getObject const):
(Inspector::BackendDispatcher::sendResponse):

Source/WebKit:

Reviewed by Myles Maxfield.

I manually verified that before this change, DYLD won't let it launch or it calls a missing selector,
but after this change it launches and loads web pages.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _inspectorDelegate]):
(-[WKWebView _setInspectorDelegate:]):

Source/WTF:

Reviewed by Myles Maxfield

  • wtf/PlatformHave.h:
  • wtf/text/WTFString.h:
  • wtf/text/cocoa/StringCocoa.mm:

(WTF::String::String):

Location:
trunk/Source
Files:
1 added
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r273502 r273515  
     12021-02-25  Alex Christensen  <achristensen@webkit.org>
     2
     3        Add stubs to enable SafariForWebKitDevelopment to launch
     4        https://bugs.webkit.org/show_bug.cgi?id=222388
     5
     6        Reviewed by Myles Maxfield.
     7
     8        * JavaScriptCore.xcodeproj/project.pbxproj:
     9        * runtime/SymbolStubsForSafariCompatibility.mm: Added.
     10        (WTF::String::String):
     11        (WTF::JSONImpl::ObjectBase::getArray const):
     12        (WTF::JSONImpl::ObjectBase::getValue const):
     13        (WTF::JSONImpl::ObjectBase::getObject const):
     14        (Inspector::BackendDispatcher::sendResponse):
     15
    1162021-02-25  Razvan Caliman  <rcaliman@apple.com>
    217

  • trunk/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

    r273484 r273515  
    17931793                DE26E9031CB5DD0500D2BE82 /* BuiltinExecutableCreator.h in Headers */ = {isa = PBXBuildFile; fileRef = DE26E9021CB5DD0500D2BE82 /* BuiltinExecutableCreator.h */; };
    17941794                DEA7E2451BBC677F00D78440 /* JSTypedArrayViewPrototype.h in Headers */ = {isa = PBXBuildFile; fileRef = 53917E7C1B791106000EBD33 /* JSTypedArrayViewPrototype.h */; settings = {ATTRIBUTES = (Private, ); }; };
     1795                DFBC2CA625E6D5B90081BDD1 /* SymbolStubsForSafariCompatibility.mm in Sources */ = {isa = PBXBuildFile; fileRef = DFBC2CA525E6D5790081BDD1 /* SymbolStubsForSafariCompatibility.mm */; };
    17951796                E124A8F70E555775003091F1 /* OpaqueJSString.h in Headers */ = {isa = PBXBuildFile; fileRef = E124A8F50E555775003091F1 /* OpaqueJSString.h */; settings = {ATTRIBUTES = (Private, ); }; };
    17961797                E307178324C7827100DF0644 /* IntlRelativeTimeFormat.h in Headers */ = {isa = PBXBuildFile; fileRef = A3BF885024480BE1001B9F35 /* IntlRelativeTimeFormat.h */; };
    … …  
    50005001                DE26E9061CB5DD9600D2BE82 /* BuiltinExecutableCreator.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = BuiltinExecutableCreator.cpp; sourceTree = "<group>"; };
    50015002                DE5A09FF1BA3AC3E003D4424 /* IntrinsicEmitter.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = IntrinsicEmitter.cpp; sourceTree = "<group>"; };
     5003                DFBC2CA525E6D5790081BDD1 /* SymbolStubsForSafariCompatibility.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = SymbolStubsForSafariCompatibility.mm; sourceTree = "<group>"; };
    50025004                E124A8F50E555775003091F1 /* OpaqueJSString.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OpaqueJSString.h; sourceTree = "<group>"; };
    50035005                E124A8F60E555775003091F1 /* OpaqueJSString.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = OpaqueJSString.cpp; sourceTree = "<group>"; };
    … …  
    78417843                                705B41A91A6E501E00716757 /* SymbolPrototype.cpp */,
    78427844                                705B41AA1A6E501E00716757 /* SymbolPrototype.h */,
     7845                                DFBC2CA525E6D5790081BDD1 /* SymbolStubsForSafariCompatibility.mm */,
    78437846                                0F919D2715856770004A4E7D /* SymbolTable.cpp */,
    78447847                                14A396A60CD2933100B5B4FF /* SymbolTable.h */,
    … …  
    1153911542                                E38E8790254B978400F6F9E4 /* JSDateMath.cpp in Sources */,
    1154011543                                536B319E1F735F160037FC33 /* LowLevelInterpreter.cpp in Sources */,
     11544                                DFBC2CA625E6D5B90081BDD1 /* SymbolStubsForSafariCompatibility.mm in Sources */,
    1154111545                                0FF4274A158EBE91004CB9FF /* udis86.c in Sources */,
    1154211546                                0FF42740158EBE8B004CB9FF /* udis86_decode.c in Sources */,

  • trunk/Source/WTF/ChangeLog

    r273503 r273515  
     12021-02-25  Alex Christensen  <achristensen@webkit.org>
     2
     3        Add stubs to enable SafariForWebKitDevelopment to launch
     4        https://bugs.webkit.org/show_bug.cgi?id=222388
     5
     6        Reviewed by Myles Maxfield
     7
     8        * wtf/PlatformHave.h:
     9        * wtf/text/WTFString.h:
     10        * wtf/text/cocoa/StringCocoa.mm:
     11        (WTF::String::String):
     12
    1132021-02-25  Brent Fulgham  <bfulgham@apple.com>
    214

  • trunk/Source/WTF/wtf/PlatformHave.h

    r273288 r273515  
    421421#endif
    422422
     423#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 110300
     424#define HAVE_SAFARI_FOR_WEBKIT_DEVELOPMENT_REQUIRING_EXTRA_SYMBOLS 1
     425#endif
     426
    423427#if PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED < 140000
    424428#define HAVE_BROKEN_DOWNLOAD_RESUME_UNLINK 1

  • trunk/Source/WTF/wtf/text/WTFString.h

    r272752 r273515  
    320320
    321321#ifdef __OBJC__
     322#if HAVE(SAFARI_FOR_WEBKIT_DEVELOPMENT_REQUIRING_EXTRA_SYMBOLS)
     323    WTF_EXPORT_PRIVATE String(NSString *);
     324#else
    322325    String(NSString *string)
    323326        : String((__bridge CFStringRef)string) { }
     327#endif
    324328
    325329    // This conversion converts the null string to an empty NSString rather than to nil.

  • trunk/Source/WTF/wtf/text/cocoa/StringCocoa.mm

    r272752 r273515  
    2626namespace WTF {
    2727
     28#if HAVE(SAFARI_FOR_WEBKIT_DEVELOPMENT_REQUIRING_EXTRA_SYMBOLS)
     29String::String(NSString *string)
     30    : String((__bridge CFStringRef)string) { }
     31#endif
     32
    2833RetainPtr<id> makeNSArrayElement(const String& vectorElement)
    2934{

  • trunk/Source/WebKit/ChangeLog

    r273510 r273515  
     12021-02-25  Alex Christensen  <achristensen@webkit.org>
     2
     3        Add stubs to enable SafariForWebKitDevelopment to launch
     4        https://bugs.webkit.org/show_bug.cgi?id=222388
     5
     6        Reviewed by Myles Maxfield.
     7
     8        I manually verified that before this change, DYLD won't let it launch or it calls a missing selector,
     9        but after this change it launches and loads web pages.
     10
     11        * UIProcess/API/Cocoa/WKWebView.mm:
     12        (-[WKWebView _inspectorDelegate]):
     13        (-[WKWebView _setInspectorDelegate:]):
     14
    1152021-02-25  Chris Dumez  <cdumez@apple.com>
    216

  • trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm

    r273484 r273515  
    17161716}
    17171717
     1718#if HAVE(SAFARI_FOR_WEBKIT_DEVELOPMENT_REQUIRING_EXTRA_SYMBOLS)
     1719- (id <_WKInspectorDelegate>)_inspectorDelegate
     1720{
     1721    // This is needed to launch SafariForWebKitDevelopment on Big Sur with an open source WebKit build.
     1722    // FIXME: Remove this after we release a Safari after Safari 14.
     1723    return nil;
     1724}
     1725
     1726- (void)_setInspectorDelegate:(id<_WKInspectorDelegate>)delegate
     1727{
     1728    // This is needed to launch SafariForWebKitDevelopment on Big Sur with an open source WebKit build.
     1729    // FIXME: Remove this after we release a Safari after Safari 14.
     1730}
     1731#endif
     1732
    17181733- (_WKFrameHandle *)_mainFrame
    17191734{
Note: See TracChangeset for help on using the changeset viewer.