Changeset 274111 in webkit

Timestamp:

Mar 8, 2021, 2:47:21 PM (4 years ago)

Author:

weinig@apple.com

Message:

Add preference reseting to WebKitLegacy Windows to simplify testing reset
​https://bugs.webkit.org/show_bug.cgi?id=222865

Reviewed by Brent Fulgham.

Source/WebKitLegacy/win:

Add resetForTesting() function to allow easy reseting of all preferences
for testing, matching functionality added to Cocoa WebKitLegacy.

• Interfaces/IWebPreferencesPrivate.idl:
• WebPreferences.cpp:

(WebPreferences::resetForTesting):

• WebPreferences.h:

Tools:

• DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):
Call the new resetForTesting() method to ensure all values are reset back
to defaults for each test without have to explicitly list them.

Location:

trunk

Files:

• Source/WebKitLegacy/win/ChangeLog (modified) (1 diff)
• Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl (modified) (1 diff)
• Source/WebKitLegacy/win/WebPreferences.cpp (modified) (1 diff)
• Source/WebKitLegacy/win/WebPreferences.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/DumpRenderTree/win/DumpRenderTree.cpp (modified) (1 diff)

trunk/Source/WebKitLegacy/win/ChangeLog

@@ +1 @@
+2021-03-08  Sam Weinig  <weinig@apple.com>
+
+        Add preference reseting to WebKitLegacy Windows to simplify testing reset
+        https://bugs.webkit.org/show_bug.cgi?id=222865
+
+        Reviewed by Brent Fulgham.
+
+        Add resetForTesting() function to allow easy reseting of all preferences
+        for testing, matching functionality added to Cocoa WebKitLegacy.
+
+        * Interfaces/IWebPreferencesPrivate.idl:
+        * WebPreferences.cpp:
+        (WebPreferences::resetForTesting):
+        * WebPreferences.h:
+
 2021-03-08  Stephan Szabo  <stephan.szabo@sony.com>
 

trunk/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl

@@ -278 +278 @@
     HRESULT overscrollBehaviorEnabled([ out, retval ] BOOL*);
     HRESULT setOverscrollBehaviorEnabled([in] BOOL enabled);
-}
+    HRESULT resetForTesting();
+}
+
+// NOTE: Please do not add any more preferences that are only for testing purposes. Instead,
+// please use the generalized set<type>PreferenceForTesting() functions.

trunk/Source/WebKitLegacy/win/WebPreferences.cpp

@@ -2612 +2612 @@
     return S_OK;
 }
+
+HRESULT WebPreferences::resetForTesting()
+{
+    load();
+    return S_OK;
+}

trunk/Source/WebKitLegacy/win/WebPreferences.h

@@ -316 +316 @@
     virtual HRESULT STDMETHODCALLTYPE overscrollBehaviorEnabled(_Out_ BOOL*);
     virtual HRESULT STDMETHODCALLTYPE setOverscrollBehaviorEnabled(BOOL);
+    virtual HRESULT STDMETHODCALLTYPE resetForTesting();
 
     // WebPreferences

trunk/Tools/ChangeLog

@@ +1 @@
+2021-03-08  Sam Weinig  <weinig@apple.com>
+
+        Add preference reseting to WebKitLegacy Windows to simplify testing reset
+        https://bugs.webkit.org/show_bug.cgi?id=222865
+
+        Reviewed by Brent Fulgham.
+
+        * DumpRenderTree/win/DumpRenderTree.cpp:
+        (resetWebPreferencesToConsistentValues):
+        Call the new resetForTesting() method to ensure all values are reset back
+        to defaults for each test without have to explicitly list them.
+
 2021-03-08  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/DumpRenderTree/win/DumpRenderTree.cpp

@@ -838 +838 @@
     ASSERT(preferences);
 
-    enableExperimentalFeatures(preferences);
-
     preferences->setAutosaves(FALSE);
 
     COMPtr<IWebPreferencesPrivate8> prefsPrivate(Query, preferences);
     ASSERT(prefsPrivate);
+
+    prefsPrivate->resetForTesting();
+
+    enableExperimentalFeatures(preferences);
+
     prefsPrivate->setFullScreenEnabled(TRUE);