Changeset 275014 in webkit

Timestamp:

Mar 25, 2021, 5:10:54 AM (4 years ago)

Author:

berto@igalia.com

Message:

REGRESSION(r271560): [Linux] release assert in Thread::initializePlatformThreading
​https://bugs.webkit.org/show_bug.cgi?id=223069

Reviewed by Carlos Garcia Campos.

Replace an existing signal handler instead of aborting.

• wtf/posix/ThreadingPOSIX.cpp:

(WTF::Thread::initializePlatformThreading):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/posix/ThreadingPOSIX.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-03-25  Alberto Garcia  <berto@igalia.com>
+
+        REGRESSION(r271560): [Linux] release assert in Thread::initializePlatformThreading
+        https://bugs.webkit.org/show_bug.cgi?id=223069
+
+        Reviewed by Carlos Garcia Campos.
+
+        Replace an existing signal handler instead of aborting.
+
+        * wtf/posix/ThreadingPOSIX.cpp:
+        (WTF::Thread::initializePlatformThreading):
+
 2021-03-24  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/WTF/wtf/posix/ThreadingPOSIX.cpp

@@ -210 +210 @@
         // It has signal already.
         if (oldAction.sa_handler != SIG_DFL || bitwise_cast<void*>(oldAction.sa_sigaction) != bitwise_cast<void*>(SIG_DFL))
-            return false;
+            WTFLogAlways("Overriding existing handler for signal %d. Set JSC_SIGNAL_FOR_GC if you want WebKit to use a different signal", signal);
         return !sigaction(signal, &action, 0);
     };