Changeset 276715 in webkit
- Timestamp:
- Apr 28, 2021, 8:44:02 AM (4 years ago)
- Location:
- trunk/Source
- Files:
-
- 37 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WTF/ChangeLog
r276706 r276715 1 2021-04-28 Chris Dumez <cdumez@apple.com> 2 3 Drop ModernUnprefixedWebAudio & AudioWorklet experimental feature flags 4 https://bugs.webkit.org/show_bug.cgi?id=225130 5 6 Reviewed by Eric Carlson. 7 8 Drop ModernUnprefixedWebAudio & AudioWorklet experimental feature flags now that 9 these features have shipped. It also doesn't make sense to disable them given 10 that the prefixed WebAudio API is no longer exposed and there is no feature flag 11 to turn the legacy prefixed API back on. 12 13 * Scripts/Preferences/WebPreferencesExperimental.yaml: 14 1 15 2021-04-28 Kimmo Kinnunen <kkinnunen@apple.com> 2 16 -
trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
r276338 r276715 76 76 default: false 77 77 78 AudioWorkletEnabled:79 type: bool80 humanReadableName: "WebAudio AudioWorklet API"81 humanReadableDescription: "WebAudio AudioWorklet API"82 condition: ENABLE(WEB_AUDIO)83 defaultValue:84 WebKitLegacy:85 "PLATFORM(IOS_FAMILY)" : true86 default: false87 WebKit:88 default: true89 WebCore:90 default: false91 92 78 BlankAnchorTargetImpliesNoOpenerEnabled: 93 79 type: bool … … 710 696 default: false 711 697 712 ModernUnprefixedWebAudioEnabled:713 type: bool714 humanReadableName: "Modern WebAudio API"715 humanReadableDescription: "Modern and unprefixed WebAudio API"716 condition: ENABLE(WEB_AUDIO)717 defaultValue:718 WebKitLegacy:719 "PLATFORM(IOS_FAMILY)" : true720 default: false721 WebKit:722 default: true723 WebCore:724 default: false725 726 698 OpusDecoderEnabled: 727 699 type: bool -
trunk/Source/WebCore/ChangeLog
r276707 r276715 1 2021-04-28 Chris Dumez <cdumez@apple.com> 2 3 Drop ModernUnprefixedWebAudio & AudioWorklet experimental feature flags 4 https://bugs.webkit.org/show_bug.cgi?id=225130 5 6 Reviewed by Eric Carlson. 7 8 Drop ModernUnprefixedWebAudio & AudioWorklet experimental feature flags now that 9 these features have shipped. It also doesn't make sense to disable them given 10 that the prefixed WebAudio API is no longer exposed and there is no feature flag 11 to turn the legacy prefixed API back on. 12 13 * Modules/webaudio/AnalyserNode.idl: 14 * Modules/webaudio/AudioBuffer.idl: 15 * Modules/webaudio/AudioBufferSourceNode.idl: 16 * Modules/webaudio/AudioContext.idl: 17 * Modules/webaudio/AudioParamMap.idl: 18 * Modules/webaudio/AudioProcessingEvent.idl: 19 * Modules/webaudio/AudioWorklet.idl: 20 * Modules/webaudio/AudioWorkletNode.idl: 21 * Modules/webaudio/AudioWorkletNodeOptions.idl: 22 * Modules/webaudio/BaseAudioContext.idl: 23 * Modules/webaudio/BiquadFilterNode.idl: 24 * Modules/webaudio/ChannelMergerNode.idl: 25 * Modules/webaudio/ChannelSplitterNode.idl: 26 * Modules/webaudio/ConstantSourceNode.idl: 27 * Modules/webaudio/ConstantSourceOptions.idl: 28 * Modules/webaudio/ConvolverNode.idl: 29 * Modules/webaudio/DelayNode.idl: 30 * Modules/webaudio/DynamicsCompressorNode.idl: 31 * Modules/webaudio/GainNode.idl: 32 * Modules/webaudio/IIRFilterNode.idl: 33 * Modules/webaudio/MediaElementAudioSourceNode.idl: 34 * Modules/webaudio/MediaStreamAudioDestinationNode.idl: 35 * Modules/webaudio/MediaStreamAudioSourceNode.idl: 36 * Modules/webaudio/OfflineAudioContext.idl: 37 * Modules/webaudio/OscillatorNode.idl: 38 * Modules/webaudio/PannerNode.idl: 39 * Modules/webaudio/PeriodicWave.idl: 40 * Modules/webaudio/StereoPannerNode.idl: 41 * Modules/webaudio/WaveShaperNode.idl: 42 1 43 2021-04-28 Zalan Bujtas <zalan@apple.com> 2 44 -
trunk/Source/WebCore/Modules/webaudio/AnalyserNode.idl
r267813 r276715 28 28 Exposed=Window 29 29 ] interface AnalyserNode : AudioNode { 30 [EnabledBySetting= ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional AnalyserOptions options);30 [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional AnalyserOptions options); 31 31 32 32 attribute unsigned long fftSize; … … 46 46 47 47 // Real-time waveform data 48 [EnabledBySetting=ModernUnprefixedWebAudio]undefined getFloatTimeDomainData(Float32Array array);48 undefined getFloatTimeDomainData(Float32Array array); 49 49 undefined getByteTimeDomainData(Uint8Array array); 50 50 }; -
trunk/Source/WebCore/Modules/webaudio/AudioBuffer.idl
r274832 r276715 35 35 Exposed=Window 36 36 ] interface AudioBuffer { 37 [EnabledBySetting= ModernUnprefixedWebAudio] constructor(AudioBufferOptions options);37 [EnabledBySetting=WebAudio] constructor(AudioBufferOptions options); 38 38 [ImplementedAs=originalLength] readonly attribute unsigned long length; // in sample-frames 39 39 [ImplementedAs=originalDuration] readonly attribute double duration; // in seconds … … 43 43 // Channel access 44 44 [CallWith=GlobalObject] any getChannelData(unsigned long channelIndex); 45 [EnabledBySetting=ModernUnprefixedWebAudio]undefined copyFromChannel(Float32Array destination, unsigned long channelNumber, optional unsigned long bufferOffset = 0);46 [EnabledBySetting=ModernUnprefixedWebAudio]undefined copyToChannel(Float32Array source, unsigned long channelNumber, optional unsigned long bufferOffset = 0);45 undefined copyFromChannel(Float32Array destination, unsigned long channelNumber, optional unsigned long bufferOffset = 0); 46 undefined copyToChannel(Float32Array source, unsigned long channelNumber, optional unsigned long bufferOffset = 0); 47 47 }; -
trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl
r274832 r276715 30 30 Exposed=Window 31 31 ] interface AudioBufferSourceNode : AudioScheduledSourceNode { 32 [EnabledBySetting= ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional AudioBufferSourceOptions options);32 [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional AudioBufferSourceOptions options); 33 33 34 34 attribute AudioBuffer? buffer; -
trunk/Source/WebCore/Modules/webaudio/AudioContext.idl
r274832 r276715 27 27 ActiveDOMObject, 28 28 Conditional=WEB_AUDIO, 29 EnabledBySetting=WebAudio &ModernUnprefixedWebAudio,29 EnabledBySetting=WebAudio, 30 30 ExportMacro=WEBCORE_EXPORT, 31 31 JSGenerateToNativeObject, -
trunk/Source/WebCore/Modules/webaudio/AudioParamMap.idl
r268187 r276715 29 29 [ 30 30 Conditional=WEB_AUDIO, 31 EnabledBySetting= AudioWorklet,31 EnabledBySetting=WebAudio, 32 32 SkipVTableValidation, 33 33 Exposed=Window -
trunk/Source/WebCore/Modules/webaudio/AudioProcessingEvent.idl
r267813 r276715 28 28 Exposed=Window 29 29 ] interface AudioProcessingEvent : Event { 30 [EnabledBySetting= ModernUnprefixedWebAudio] constructor (DOMString type, AudioProcessingEventInit eventInitDict);30 [EnabledBySetting=WebAudio] constructor (DOMString type, AudioProcessingEventInit eventInitDict); 31 31 readonly attribute double playbackTime; 32 32 readonly attribute AudioBuffer inputBuffer; -
trunk/Source/WebCore/Modules/webaudio/AudioWorklet.idl
r267744 r276715 29 29 [ 30 30 Conditional=WEB_AUDIO, 31 EnabledBySetting= AudioWorklet,31 EnabledBySetting=WebAudio, 32 32 Exposed=Window, 33 33 JSGenerateToJSObject, -
trunk/Source/WebCore/Modules/webaudio/AudioWorkletNode.idl
r268365 r276715 30 30 ActiveDOMObject, 31 31 Conditional=WEB_AUDIO, 32 EnabledBySetting= AudioWorklet,32 EnabledBySetting=WebAudio, 33 33 Exposed=Window, 34 34 JSGenerateToJSObject, -
trunk/Source/WebCore/Modules/webaudio/AudioWorkletNodeOptions.idl
r268161 r276715 29 29 [ 30 30 Conditional=WEB_AUDIO, 31 EnabledBySetting= AudioWorklet,31 EnabledBySetting=WebAudio, 32 32 JSGenerateToJSObject 33 33 ] dictionary AudioWorkletNodeOptions : AudioNodeOptions { -
trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.idl
r274832 r276715 28 28 Conditional=WEB_AUDIO, 29 29 CustomToJSObject, 30 EnabledBySetting=WebAudio &ModernUnprefixedWebAudio,30 EnabledBySetting=WebAudio, 31 31 ExportMacro=WEBCORE_EXPORT, 32 32 Exposed=Window … … 44 44 readonly attribute AudioListener listener; 45 45 46 [SameObject, SecureContext , EnabledBySetting=AudioWorklet] readonly attribute AudioWorklet audioWorklet;46 [SameObject, SecureContext] readonly attribute AudioWorklet audioWorklet; 47 47 48 48 readonly attribute AudioContextState state; -
trunk/Source/WebCore/Modules/webaudio/BiquadFilterNode.idl
r274832 r276715 29 29 Exposed=Window 30 30 ] interface BiquadFilterNode : AudioNode { 31 [EnabledBySetting= ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional BiquadFilterOptions options);31 [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional BiquadFilterOptions options); 32 32 33 33 attribute BiquadFilterType type; -
trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.idl
r267813 r276715 32 32 Exposed=Window 33 33 ] interface ChannelMergerNode : AudioNode { 34 [EnabledBySetting= ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional ChannelMergerOptions options);34 [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional ChannelMergerOptions options); 35 35 }; -
trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.idl
r267813 r276715 28 28 Exposed=Window 29 29 ] interface ChannelSplitterNode : AudioNode { 30 [EnabledBySetting= ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional ChannelSplitterOptions options);30 [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional ChannelSplitterOptions options); 31 31 }; -
trunk/Source/WebCore/Modules/webaudio/ConstantSourceNode.idl
r267813 r276715 27 27 Conditional=WEB_AUDIO, 28 28 JSGenerateToJSObject, 29 EnabledBySetting= ModernUnprefixedWebAudio,29 EnabledBySetting=WebAudio, 30 30 Exposed=Window 31 31 ] interface ConstantSourceNode : AudioScheduledSourceNode { -
trunk/Source/WebCore/Modules/webaudio/ConstantSourceOptions.idl
r265689 r276715 26 26 [ 27 27 Conditional=WEB_AUDIO, 28 EnabledBySetting= ModernUnprefixedWebAudio28 EnabledBySetting=WebAudio 29 29 ] dictionary ConstantSourceOptions { 30 30 float offset = 1; -
trunk/Source/WebCore/Modules/webaudio/ConvolverNode.idl
r267813 r276715 30 30 Exposed=Window 31 31 ] interface ConvolverNode : AudioNode { 32 [EnabledBySetting= ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional ConvolverOptions options);32 [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional ConvolverOptions options); 33 33 34 34 attribute AudioBuffer? buffer; -
trunk/Source/WebCore/Modules/webaudio/DelayNode.idl
r267813 r276715 28 28 Exposed=Window 29 29 ] interface DelayNode : AudioNode { 30 [EnabledBySetting= ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional DelayOptions options);30 [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional DelayOptions options); 31 31 32 32 readonly attribute AudioParam delayTime; -
trunk/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.idl
r267813 r276715 29 29 Exposed=Window 30 30 ] interface DynamicsCompressorNode : AudioNode { 31 [EnabledBySetting= ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional DynamicsCompressorOptions options);31 [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional DynamicsCompressorOptions options); 32 32 33 33 readonly attribute AudioParam threshold; // in Decibels -
trunk/Source/WebCore/Modules/webaudio/GainNode.idl
r267813 r276715 28 28 Exposed=Window 29 29 ] interface GainNode : AudioNode { 30 [EnabledBySetting= ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional GainOptions options);30 [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional GainOptions options); 31 31 32 32 readonly attribute AudioParam gain; -
trunk/Source/WebCore/Modules/webaudio/IIRFilterNode.idl
r274832 r276715 26 26 Conditional=WEB_AUDIO, 27 27 JSGenerateToJSObject, 28 EnabledBySetting= ModernUnprefixedWebAudio,28 EnabledBySetting=WebAudio, 29 29 Exposed=Window 30 30 ] interface IIRFilterNode : AudioNode { -
trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.idl
r267813 r276715 29 29 Exposed=Window 30 30 ] interface MediaElementAudioSourceNode : AudioNode { 31 [EnabledBySetting= ModernUnprefixedWebAudio] constructor (AudioContext context, MediaElementAudioSourceOptions options);31 [EnabledBySetting=WebAudio] constructor (AudioContext context, MediaElementAudioSourceOptions options); 32 32 33 33 readonly attribute HTMLMediaElement mediaElement; -
trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.idl
r267813 r276715 28 28 Exposed=Window 29 29 ] interface MediaStreamAudioDestinationNode : AudioNode { 30 [EnabledBySetting= ModernUnprefixedWebAudio] constructor (AudioContext context, optional AudioNodeOptions options);30 [EnabledBySetting=WebAudio] constructor (AudioContext context, optional AudioNodeOptions options); 31 31 readonly attribute MediaStream stream; 32 32 }; -
trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.idl
r267813 r276715 28 28 Exposed=Window 29 29 ] interface MediaStreamAudioSourceNode : AudioNode { 30 [EnabledBySetting= ModernUnprefixedWebAudio] constructor (AudioContext context, MediaStreamAudioSourceOptions options);30 [EnabledBySetting=WebAudio] constructor (AudioContext context, MediaStreamAudioSourceOptions options); 31 31 32 32 readonly attribute MediaStream mediaStream; -
trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl
r267813 r276715 25 25 [ 26 26 Conditional=WEB_AUDIO, 27 EnabledBySetting= ModernUnprefixedWebAudio,27 EnabledBySetting=WebAudio, 28 28 JSGenerateToJSObject, 29 29 Exposed=Window -
trunk/Source/WebCore/Modules/webaudio/OscillatorNode.idl
r267813 r276715 30 30 Exposed=Window 31 31 ] interface OscillatorNode : AudioScheduledSourceNode { 32 [EnabledBySetting= ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional OscillatorOptions options);32 [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional OscillatorOptions options); 33 33 34 34 attribute OscillatorType type; -
trunk/Source/WebCore/Modules/webaudio/PannerNode.idl
r274832 r276715 26 26 Conditional=WEB_AUDIO, 27 27 JSGenerateToJSObject, 28 EnabledBySetting= ModernUnprefixedWebAudio,28 EnabledBySetting=WebAudio, 29 29 Exposed=Window 30 30 ] interface PannerNode : AudioNode { -
trunk/Source/WebCore/Modules/webaudio/PeriodicWave.idl
r267813 r276715 29 29 Exposed=Window 30 30 ] interface PeriodicWave { 31 [EnabledBySetting= ModernUnprefixedWebAudio] constructor(BaseAudioContext context, optional PeriodicWaveOptions options);31 [EnabledBySetting=WebAudio] constructor(BaseAudioContext context, optional PeriodicWaveOptions options); 32 32 }; -
trunk/Source/WebCore/Modules/webaudio/StereoPannerNode.idl
r267813 r276715 27 27 Conditional=WEB_AUDIO, 28 28 JSGenerateToJSObject, 29 EnabledBySetting= ModernUnprefixedWebAudio,29 EnabledBySetting=WebAudio, 30 30 Exposed=Window 31 31 ] interface StereoPannerNode : AudioNode { -
trunk/Source/WebCore/Modules/webaudio/WaveShaperNode.idl
r267813 r276715 28 28 Exposed=Window 29 29 ] interface WaveShaperNode : AudioNode { 30 [EnabledBySetting= ModernUnprefixedWebAudio] constructor(BaseAudioContext context, optional WaveShaperOptions options);30 [EnabledBySetting=WebAudio] constructor(BaseAudioContext context, optional WaveShaperOptions options); 31 31 32 32 attribute Float32Array? curve; -
trunk/Source/WebKitLegacy/mac/ChangeLog
r276677 r276715 1 2021-04-28 Chris Dumez <cdumez@apple.com> 2 3 Drop ModernUnprefixedWebAudio & AudioWorklet experimental feature flags 4 https://bugs.webkit.org/show_bug.cgi?id=225130 5 6 Reviewed by Eric Carlson. 7 8 Drop ModernUnprefixedWebAudio & AudioWorklet experimental feature flags now that 9 these features have shipped. It also doesn't make sense to disable them given 10 that the prefixed WebAudio API is no longer exposed and there is no feature flag 11 to turn the legacy prefixed API back on. 12 13 * WebView/WebPreferenceKeysPrivate.h: 14 * WebView/WebPreferences.mm: 15 (-[WebPreferences modernUnprefixedWebAudioEnabled]): Deleted. 16 (-[WebPreferences setModernUnprefixedWebAudioEnabled:]): Deleted. 17 (-[WebPreferences audioWorkletEnabled]): Deleted. 18 (-[WebPreferences setAudioWorkletEnabled:]): Deleted. 19 * WebView/WebPreferencesPrivate.h: 20 1 21 2021-04-27 Alex Christensen <achristensen@webkit.org> 2 22 -
trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
r274810 r276715 253 253 // FIXME: If these are not used anywhere, we should remove them and only use WebFeature mechanism for the preference. 254 254 #define WebKitUserGesturePromisePropagationEnabledPreferenceKey @"WebKitUserGesturePromisePropagationEnabled" 255 #define WebKitModernUnprefixedWebAudioEnabledPreferenceKey @"WebKitModernUnprefixedWebAudioEnabled"256 #define WebKitAudioWorkletEnabledPreferenceKey @"WebKitAudioWorkletEnabled"257 255 #define WebKitRequestIdleCallbackEnabledPreferenceKey @"WebKitRequestIdleCallbackEnabled" 258 256 #define WebKitHighlightAPIEnabledPreferenceKey @"WebKitHighlightAPIEnabled" -
trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
r276652 r276715 3076 3076 } 3077 3077 3078 - (BOOL)modernUnprefixedWebAudioEnabled3079 {3080 return [self _boolValueForKey:WebKitModernUnprefixedWebAudioEnabledPreferenceKey];3081 }3082 3083 - (void)setModernUnprefixedWebAudioEnabled:(BOOL)enabled3084 {3085 [self _setBoolValue:enabled forKey:WebKitModernUnprefixedWebAudioEnabledPreferenceKey];3086 }3087 3088 - (BOOL)audioWorkletEnabled3089 {3090 return [self _boolValueForKey:WebKitAudioWorkletEnabledPreferenceKey];3091 }3092 3093 - (void)setAudioWorkletEnabled:(BOOL)enabled3094 {3095 [self _setBoolValue:enabled forKey:WebKitAudioWorkletEnabledPreferenceKey];3096 }3097 3098 3078 - (BOOL)requestIdleCallbackEnabled 3099 3079 { -
trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
r274810 r276715 327 327 @interface WebPreferences (WebPrivatePreferencesConvertedToWebFeature) 328 328 @property (nonatomic) BOOL userGesturePromisePropagationEnabled; 329 @property (nonatomic) BOOL modernUnprefixedWebAudioEnabled;330 @property (nonatomic) BOOL audioWorkletEnabled;331 329 @property (nonatomic) BOOL requestIdleCallbackEnabled; 332 330 @property (nonatomic) BOOL highlightAPIEnabled; -
trunk/Source/WebKitLegacy/win/WebView.cpp
r276468 r276715 5537 5537 settings.setWebAudioEnabled(true); 5538 5538 settings.setPrefixedWebAudioEnabled(false); 5539 settings.setModernUnprefixedWebAudioEnabled(true);5540 5539 #endif // ENABLE(WEB_AUDIO) 5541 5540
Note:
See TracChangeset
for help on using the changeset viewer.