Changeset 277043 in webkit

Timestamp:

May 5, 2021, 2:52:35 PM (4 years ago)

Author:

aakash_jain@apple.com

Message:

[build.webkit.org] Add a build step to set appropriate permissions on uploaded test results
​https://bugs.webkit.org/show_bug.cgi?id=225415

Reviewed by Dewei Zhu.

• CISupport/build-webkit-org/factories.py:

(TestFactory.init): Added the build-step.

• CISupport/build-webkit-org/steps.py:

(ExtractTestResults.resultDirectoryURL):
(SetPermissions): Build step to set permissions on uploaded test result directory.

Location:

trunk/Tools

Files:

• CISupport/build-webkit-org/factories.py (modified) (1 diff)
• CISupport/build-webkit-org/steps.py (modified) (2 diffs)
• CISupport/build-webkit-org/steps_unittest.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/CISupport/build-webkit-org/factories.py

@@ -115 +115 @@
             self.addStep(UploadTestResults())
             self.addStep(ExtractTestResults())
+            self.addStep(SetPermissions())
         if platform == "gtk":
             self.addStep(RunGtkAPITests())

trunk/Tools/CISupport/build-webkit-org/steps.py

@@ -1118 +1118 @@
 
     def resultDirectoryURL(self):
+        self.setProperty('result_directory', self.resultDirectory)
         return self.resultDirectory.replace('public_html/', '/') + '/'
 
@@ -1127 +1128 @@
         self.addCustomURLs()
         return master.MasterShellCommand.finished(self, result)
+
+
+class SetPermissions(master.MasterShellCommand):
+    name = 'set-permissions'
+
+    def __init__(self, **kwargs):
+        resultDirectory = Interpolate('%(prop:result_directory)s')
+        kwargs['command'] = ['chmod', 'a+rx', resultDirectory]
+        kwargs['logEnviron'] = False
+        master.MasterShellCommand.__init__(self, **kwargs)
 
 

trunk/Tools/CISupport/build-webkit-org/steps_unittest.py

@@ -963 +963 @@
         self.expectOutcome(result=FAILURE, state_string='9 JSC tests failed')
         return self.runStep()
+
+
+class TestSetPermissions(BuildStepMixinAdditions, unittest.TestCase):
+    def setUp(self):
+        self.longMessage = True
+        return self.setUpBuildStep()
+
+    def tearDown(self):
+        return self.tearDownBuildStep()
+
+    def test_success(self):
+        self.setupStep(SetPermissions())
+        self.setProperty('result_directory', 'public_html/results/Apple-BigSur-Release-WK2-Tests/r277034 (2346)')
+        self.expectLocalCommands(
+            ExpectMasterShellCommand(command=['chmod', 'a+rx', 'public_html/results/Apple-BigSur-Release-WK2-Tests/r277034 (2346)'])
+            + 0,
+        )
+        self.expectOutcome(result=SUCCESS, state_string='Ran')
+        return self.runStep()
+
+    def test_failure(self):
+        self.setupStep(SetPermissions())
+        self.setProperty('result_directory', 'testdir')
+        self.expectLocalCommands(
+            ExpectMasterShellCommand(command=['chmod', 'a+rx', 'testdir'])
+            + 1,
+        )
+        self.expectOutcome(result=FAILURE, state_string='failed (1) (failure)')
+        return self.runStep()

trunk/Tools/ChangeLog

@@ +1 @@
+2021-05-05  Aakash Jain  <aakash_jain@apple.com>
+
+        [build.webkit.org] Add a build step to set appropriate permissions on uploaded test results
+        https://bugs.webkit.org/show_bug.cgi?id=225415
+
+        Reviewed by Dewei Zhu.
+
+        * CISupport/build-webkit-org/factories.py:
+        (TestFactory.__init__): Added the build-step.
+        * CISupport/build-webkit-org/steps.py:
+        (ExtractTestResults.resultDirectoryURL):
+        (SetPermissions): Build step to set permissions on uploaded test result directory.
+
 2021-05-05  Alicia Boya García  <aboya@igalia.com>